mirror of
https://github.com/affaan-m/everything-claude-code.git
synced 2026-06-30 19:00:57 +08:00
refactor(commands): remove duplicated content in skill-create and learn-eval (#2348)
skill-create: drop the "Example Output" section (53 lines) — it re-rendered the same skeleton already defined by the Step 3 output template, just with filled-in `my-app` values. learn-eval: drop the "Next Action" column from the 5b verdict table — it duplicated Step 6's "Verdict-specific confirmation flow". The table now carries Verdict + Meaning, and a pointer to Step 6 as the single source for each verdict's action. No behavior, frontmatter, or design-rationale changes.
This commit is contained in:
parent
7976e6faf2
commit
1c3a989ea6
@ -64,14 +64,14 @@ origin: auto-extracted
|
|||||||
|
|
||||||
### 5b. Holistic verdict
|
### 5b. Holistic verdict
|
||||||
|
|
||||||
Synthesize the checklist results and draft quality, then choose **one** of the following:
|
Synthesize the checklist results and draft quality, then choose **one** of the following (Step 6 defines the action each verdict triggers):
|
||||||
|
|
||||||
| Verdict | Meaning | Next Action |
|
| Verdict | Meaning |
|
||||||
|---------|---------|-------------|
|
|---------|---------|
|
||||||
| **Save** | Unique, specific, well-scoped | Proceed to Step 6 |
|
| **Save** | Unique, specific, well-scoped |
|
||||||
| **Improve then Save** | Valuable but needs refinement | List improvements → revise → re-evaluate (once) |
|
| **Improve then Save** | Valuable but needs refinement |
|
||||||
| **Absorb into [X]** | Should be appended to an existing skill | Show target skill and additions → Step 6 |
|
| **Absorb into [X]** | Should be appended to an existing skill |
|
||||||
| **Drop** | Trivial, redundant, or too abstract | Explain reasoning and stop |
|
| **Drop** | Trivial, redundant, or too abstract |
|
||||||
|
|
||||||
**Guideline dimensions** (informing the verdict, not scored):
|
**Guideline dimensions** (informing the verdict, not scored):
|
||||||
|
|
||||||
|
|||||||
@ -102,59 +102,6 @@ Prefix commits with: feat:, fix:, chore:, docs:, test:, refactor:
|
|||||||
- {percentage}% follow conventional commit format
|
- {percentage}% follow conventional commit format
|
||||||
```
|
```
|
||||||
|
|
||||||
## Example Output
|
|
||||||
|
|
||||||
Running `/skill-create` on a TypeScript project might produce:
|
|
||||||
|
|
||||||
```markdown
|
|
||||||
---
|
|
||||||
name: my-app-patterns
|
|
||||||
description: Coding patterns from my-app repository
|
|
||||||
version: 1.0.0
|
|
||||||
source: local-git-analysis
|
|
||||||
analyzed_commits: 150
|
|
||||||
---
|
|
||||||
|
|
||||||
# My App Patterns
|
|
||||||
|
|
||||||
## Commit Conventions
|
|
||||||
|
|
||||||
This project uses **conventional commits**:
|
|
||||||
- `feat:` - New features
|
|
||||||
- `fix:` - Bug fixes
|
|
||||||
- `chore:` - Maintenance tasks
|
|
||||||
- `docs:` - Documentation updates
|
|
||||||
|
|
||||||
## Code Architecture
|
|
||||||
|
|
||||||
```
|
|
||||||
src/
|
|
||||||
├── components/ # React components (PascalCase.tsx)
|
|
||||||
├── hooks/ # Custom hooks (use*.ts)
|
|
||||||
├── utils/ # Utility functions
|
|
||||||
├── types/ # TypeScript type definitions
|
|
||||||
└── services/ # API and external services
|
|
||||||
```
|
|
||||||
|
|
||||||
## Workflows
|
|
||||||
|
|
||||||
### Adding a New Component
|
|
||||||
1. Create `src/components/ComponentName.tsx`
|
|
||||||
2. Add tests in `src/components/__tests__/ComponentName.test.tsx`
|
|
||||||
3. Export from `src/components/index.ts`
|
|
||||||
|
|
||||||
### Database Migration
|
|
||||||
1. Modify `src/db/schema.ts`
|
|
||||||
2. Run `pnpm db:generate`
|
|
||||||
3. Run `pnpm db:migrate`
|
|
||||||
|
|
||||||
## Testing Patterns
|
|
||||||
|
|
||||||
- Test files: `__tests__/` directories or `.test.ts` suffix
|
|
||||||
- Coverage target: 80%+
|
|
||||||
- Framework: Vitest
|
|
||||||
```
|
|
||||||
|
|
||||||
## GitHub App Integration
|
## GitHub App Integration
|
||||||
|
|
||||||
For advanced features (10k+ commits, team sharing, auto-PRs), use the [Skill Creator GitHub App](https://github.com/apps/skill-creator):
|
For advanced features (10k+ commits, team sharing, auto-PRs), use the [Skill Creator GitHub App](https://github.com/apps/skill-creator):
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user