From 6626e804f92610870e1e70fd2d5535311d3902c4 Mon Sep 17 00:00:00 2001 From: Affaan Mustafa Date: Thu, 11 Jun 2026 00:56:55 -0400 Subject: [PATCH] chore: pin rust toolchain to 1.96 for edition2024 deps (#2228) - add ecc2/rust-toolchain.toml pinning stable 1.96 (deps now require edition2024, which needs rustc 1.85+; local 1.84 could no longer build) - make git test fixtures hermetic: disable core.hooksPath inside temp repos so global identity-checking pre-push hooks cannot fail tests --- ecc2/rust-toolchain.toml | 4 ++++ ecc2/src/session/manager.rs | 3 +++ ecc2/src/tui/dashboard.rs | 3 +++ 3 files changed, 10 insertions(+) create mode 100644 ecc2/rust-toolchain.toml diff --git a/ecc2/rust-toolchain.toml b/ecc2/rust-toolchain.toml new file mode 100644 index 00000000..8bc491ef --- /dev/null +++ b/ecc2/rust-toolchain.toml @@ -0,0 +1,4 @@ +[toolchain] +# Minimum 1.85 required: several dependencies use edition2024. +channel = "1.96" +components = ["rustfmt", "clippy"] diff --git a/ecc2/src/session/manager.rs b/ecc2/src/session/manager.rs index ca061aae..8de49c8e 100644 --- a/ecc2/src/session/manager.rs +++ b/ecc2/src/session/manager.rs @@ -5043,6 +5043,9 @@ mod tests { run_git(path, ["init", "-q"])?; run_git(path, ["config", "user.name", "ECC Tests"])?; run_git(path, ["config", "user.email", "ecc-tests@example.com"])?; + // Keep fixtures hermetic: a global core.hooksPath (e.g. identity-checking + // pre-push hooks) must not run inside test repos. + run_git(path, ["config", "core.hooksPath", "hooks-disabled"])?; fs::write(path.join("README.md"), "hello\n")?; run_git(path, ["add", "README.md"])?; run_git(path, ["commit", "-qm", "init"])?; diff --git a/ecc2/src/tui/dashboard.rs b/ecc2/src/tui/dashboard.rs index 396f3402..c98b4e2c 100644 --- a/ecc2/src/tui/dashboard.rs +++ b/ecc2/src/tui/dashboard.rs @@ -15047,6 +15047,9 @@ diff --git a/src/lib.rs b/src/lib.rs run_git(path, &["init", "-q"])?; run_git(path, &["config", "user.name", "ECC Tests"])?; run_git(path, &["config", "user.email", "ecc-tests@example.com"])?; + // Keep fixtures hermetic: a global core.hooksPath (e.g. identity-checking + // pre-push hooks) must not run inside test repos. + run_git(path, &["config", "core.hooksPath", "hooks-disabled"])?; fs::write(path.join("README.md"), "hello\n")?; run_git(path, &["add", "README.md"])?; run_git(path, &["commit", "-qm", "init"])?;