Merge pull request #2110 from code-yeongyu/fix/boulder-continuation-agent-check
fix(atlas): boulder continuation deadlock after /start-work + 30s→5s cooldown
This commit is contained in:
commit
235bb58779
@ -92,17 +92,15 @@ export function createAtlasEventHandler(input: {
|
|||||||
const lastAgentKey = getAgentConfigKey(lastAgent ?? "")
|
const lastAgentKey = getAgentConfigKey(lastAgent ?? "")
|
||||||
const requiredAgent = getAgentConfigKey(boulderState.agent ?? "atlas")
|
const requiredAgent = getAgentConfigKey(boulderState.agent ?? "atlas")
|
||||||
const lastAgentMatchesRequired = lastAgentKey === requiredAgent
|
const lastAgentMatchesRequired = lastAgentKey === requiredAgent
|
||||||
const boulderAgentWasNotExplicitlySet = boulderState.agent === undefined
|
|
||||||
const boulderAgentDefaultsToAtlas = requiredAgent === "atlas"
|
const boulderAgentDefaultsToAtlas = requiredAgent === "atlas"
|
||||||
const lastAgentIsSisyphus = lastAgentKey === "sisyphus"
|
const lastAgentIsSisyphus = lastAgentKey === "sisyphus"
|
||||||
const allowSisyphusWhenDefaultAtlas = boulderAgentWasNotExplicitlySet && boulderAgentDefaultsToAtlas && lastAgentIsSisyphus
|
const allowSisyphusForAtlasBoulder = boulderAgentDefaultsToAtlas && lastAgentIsSisyphus
|
||||||
const agentMatches = lastAgentMatchesRequired || allowSisyphusWhenDefaultAtlas
|
const agentMatches = lastAgentMatchesRequired || allowSisyphusForAtlasBoulder
|
||||||
if (!agentMatches) {
|
if (!agentMatches) {
|
||||||
log(`[${HOOK_NAME}] Skipped: last agent does not match boulder agent`, {
|
log(`[${HOOK_NAME}] Skipped: last agent does not match boulder agent`, {
|
||||||
sessionID,
|
sessionID,
|
||||||
lastAgent: lastAgent ?? "unknown",
|
lastAgent: lastAgent ?? "unknown",
|
||||||
requiredAgent,
|
requiredAgent,
|
||||||
boulderAgentExplicitlySet: boulderState.agent !== undefined,
|
|
||||||
})
|
})
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|||||||
@ -933,8 +933,8 @@ describe("atlas hook", () => {
|
|||||||
expect(callArgs.body.parts[0].text).toContain("2 remaining")
|
expect(callArgs.body.parts[0].text).toContain("2 remaining")
|
||||||
})
|
})
|
||||||
|
|
||||||
test("should not inject when last agent does not match boulder agent", async () => {
|
test("should inject when last agent is sisyphus and boulder targets atlas explicitly", async () => {
|
||||||
// given - boulder state with incomplete plan, but last agent does NOT match
|
// given - boulder explicitly set to atlas, but last agent is sisyphus (initial state after /start-work)
|
||||||
const planPath = join(TEST_DIR, "test-plan.md")
|
const planPath = join(TEST_DIR, "test-plan.md")
|
||||||
writeFileSync(planPath, "# Plan\n- [ ] Task 1\n- [ ] Task 2")
|
writeFileSync(planPath, "# Plan\n- [ ] Task 1\n- [ ] Task 2")
|
||||||
|
|
||||||
@ -947,7 +947,7 @@ describe("atlas hook", () => {
|
|||||||
}
|
}
|
||||||
writeBoulderState(TEST_DIR, state)
|
writeBoulderState(TEST_DIR, state)
|
||||||
|
|
||||||
// given - last agent is NOT the boulder agent
|
// given - last agent is sisyphus (typical state right after /start-work)
|
||||||
cleanupMessageStorage(MAIN_SESSION_ID)
|
cleanupMessageStorage(MAIN_SESSION_ID)
|
||||||
setupMessageStorage(MAIN_SESSION_ID, "sisyphus")
|
setupMessageStorage(MAIN_SESSION_ID, "sisyphus")
|
||||||
|
|
||||||
@ -962,7 +962,39 @@ describe("atlas hook", () => {
|
|||||||
},
|
},
|
||||||
})
|
})
|
||||||
|
|
||||||
// then - should NOT call prompt because agent does not match
|
// then - should call prompt because sisyphus is always allowed for atlas boulders
|
||||||
|
expect(mockInput._promptMock).toHaveBeenCalled()
|
||||||
|
})
|
||||||
|
|
||||||
|
test("should not inject when last agent is non-sisyphus and does not match boulder agent", async () => {
|
||||||
|
// given - boulder explicitly set to atlas, last agent is hephaestus (unrelated agent)
|
||||||
|
const planPath = join(TEST_DIR, "test-plan.md")
|
||||||
|
writeFileSync(planPath, "# Plan\n- [ ] Task 1\n- [ ] Task 2")
|
||||||
|
|
||||||
|
const state: BoulderState = {
|
||||||
|
active_plan: planPath,
|
||||||
|
started_at: "2026-01-02T10:00:00Z",
|
||||||
|
session_ids: [MAIN_SESSION_ID],
|
||||||
|
plan_name: "test-plan",
|
||||||
|
agent: "atlas",
|
||||||
|
}
|
||||||
|
writeBoulderState(TEST_DIR, state)
|
||||||
|
|
||||||
|
cleanupMessageStorage(MAIN_SESSION_ID)
|
||||||
|
setupMessageStorage(MAIN_SESSION_ID, "hephaestus")
|
||||||
|
|
||||||
|
const mockInput = createMockPluginInput()
|
||||||
|
const hook = createAtlasHook(mockInput)
|
||||||
|
|
||||||
|
// when
|
||||||
|
await hook.handler({
|
||||||
|
event: {
|
||||||
|
type: "session.idle",
|
||||||
|
properties: { sessionID: MAIN_SESSION_ID },
|
||||||
|
},
|
||||||
|
})
|
||||||
|
|
||||||
|
// then - should NOT call prompt because hephaestus does not match atlas or sisyphus
|
||||||
expect(mockInput._promptMock).not.toHaveBeenCalled()
|
expect(mockInput._promptMock).not.toHaveBeenCalled()
|
||||||
})
|
})
|
||||||
|
|
||||||
|
|||||||
@ -17,6 +17,6 @@ export const TOAST_DURATION_MS = 900
|
|||||||
export const COUNTDOWN_GRACE_PERIOD_MS = 500
|
export const COUNTDOWN_GRACE_PERIOD_MS = 500
|
||||||
|
|
||||||
export const ABORT_WINDOW_MS = 3000
|
export const ABORT_WINDOW_MS = 3000
|
||||||
export const CONTINUATION_COOLDOWN_MS = 30_000
|
export const CONTINUATION_COOLDOWN_MS = 5_000
|
||||||
export const MAX_CONSECUTIVE_FAILURES = 5
|
export const MAX_CONSECUTIVE_FAILURES = 5
|
||||||
export const FAILURE_RESET_WINDOW_MS = 5 * 60 * 1000
|
export const FAILURE_RESET_WINDOW_MS = 5 * 60 * 1000
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user