From 2c4730f0945b8832bf6eb945cdc00929c4dc5967 Mon Sep 17 00:00:00 2001 From: Kenny Date: Wed, 14 Jan 2026 15:27:48 -0500 Subject: [PATCH] Delete clean_pr_body.txt --- clean_pr_body.txt | 44 -------------------------------------------- 1 file changed, 44 deletions(-) delete mode 100644 clean_pr_body.txt diff --git a/clean_pr_body.txt b/clean_pr_body.txt deleted file mode 100644 index 61fffdb6..00000000 --- a/clean_pr_body.txt +++ /dev/null @@ -1,44 +0,0 @@ -## Summary - -Adds an automatic model fallback system that gracefully handles API failures by retrying with configured fallback models. When primary models fail due to transient errors (rate limits, 5xx, network issues), the system automatically retries with fallback models. Background tasks also properly support model fallback chains for reliability. - -## Features - -Automatic Fallback on Transient Errors: -- Rate limits and HTTP 429 errors -- Service unavailable (HTTP 503, 502) -- Capacity issues (overloaded, capacity, unavailable) -- Network errors (timeout, ECONNREFUSED, ENOTFOUND) - -Non-model errors like authentication failures or invalid input are NOT retried. - -Background Task Support: -- Background tasks properly use modelChain for fallback -- Ensures reliability for async operations - -## Implementation Details - -Core module src/features/model-fallback/ provides utilities for: -- parseModelString: Parse provider/model format -- buildModelChain: Build ordered list of models -- isModelError: Detect retryable errors -- withModelFallback: Generic retry wrapper with validation -- formatRetryErrors: Format error list for display - -Integration with sisyphus-task includes updated resolveCategoryConfig, inline retry logic, and special handling for configuration errors. - -## Fixes from Review - -✅ maxAttempts validated with Math.max(1, ...) to prevent silent failures -✅ Error matching scoped to agent.name errors only -✅ Background LaunchInput supports modelChain -✅ BackgroundTask stores modelChain field -✅ Background manager passes modelChain to prompt execution - -## Testing - -✅ 36/36 model-fallback tests passing -✅ Build successful -✅ TypeScript types valid - -This is a clean PR without auto-generated XML descriptions, fixing the authorship issue from PR #785.