diff --git a/src/agents/utils.ts b/src/agents/utils.ts index acc84813..57eb6827 100644 --- a/src/agents/utils.ts +++ b/src/agents/utils.ts @@ -10,7 +10,7 @@ import { createMetisAgent } from "./metis" import { createAtlasAgent } from "./atlas" import { createMomusAgent } from "./momus" import type { AvailableAgent, AvailableCategory, AvailableSkill } from "./dynamic-agent-prompt-builder" -import { deepMerge, fetchAvailableModels, resolveModelWithFallback, AGENT_MODEL_REQUIREMENTS, findCaseInsensitive, includesCaseInsensitive, readConnectedProvidersCache } from "../shared" +import { deepMerge, fetchAvailableModels, resolveModelWithFallback, AGENT_MODEL_REQUIREMENTS, findCaseInsensitive, includesCaseInsensitive, readConnectedProvidersCache, isModelAvailable } from "../shared" import { DEFAULT_CATEGORIES, CATEGORY_DESCRIPTIONS } from "../tools/delegate-task/constants" import { resolveMultipleSkills } from "../features/opencode-skill-loader/skill-content" import { createBuiltinSkills } from "../features/builtin-skills" @@ -222,12 +222,19 @@ export async function createBuiltinAgents( if (agentName === "atlas") continue if (includesCaseInsensitive(disabledAgents, agentName)) continue - const override = findCaseInsensitive(agentOverrides, agentName) - const requirement = AGENT_MODEL_REQUIREMENTS[agentName] - - const isPrimaryAgent = isFactory(source) && source.mode === "primary" - - const resolution = resolveModelWithFallback({ + const override = findCaseInsensitive(agentOverrides, agentName) + const requirement = AGENT_MODEL_REQUIREMENTS[agentName] + + // Check if agent requires a specific model + if (requirement?.requiresModel && availableModels) { + if (!isModelAvailable(requirement.requiresModel, availableModels)) { + continue + } + } + + const isPrimaryAgent = isFactory(source) && source.mode === "primary" + + const resolution = resolveModelWithFallback({ uiSelectedModel: isPrimaryAgent ? uiSelectedModel : undefined, userModel: override?.model, fallbackChain: requirement?.fallbackChain, diff --git a/src/tools/delegate-task/tools.ts b/src/tools/delegate-task/tools.ts index e9f7730d..eb77fe9a 100644 --- a/src/tools/delegate-task/tools.ts +++ b/src/tools/delegate-task/tools.ts @@ -13,7 +13,7 @@ import { getTaskToastManager } from "../../features/task-toast-manager" import type { ModelFallbackInfo } from "../../features/task-toast-manager/types" import { subagentSessions, getSessionAgent } from "../../features/claude-code-session-state" import { log, getAgentToolRestrictions, resolveModel, getOpenCodeConfigPaths, findByNameCaseInsensitive, equalsIgnoreCase, promptWithModelSuggestionRetry } from "../../shared" -import { fetchAvailableModels } from "../../shared/model-availability" +import { fetchAvailableModels, isModelAvailable } from "../../shared/model-availability" import { readConnectedProvidersCache } from "../../shared/connected-providers-cache" import { resolveModelWithFallback } from "../../shared/model-resolver" import { CATEGORY_MODEL_REQUIREMENTS } from "../../shared/model-requirements" @@ -117,9 +117,20 @@ export function resolveCategoryConfig( userCategories?: CategoriesConfig inheritedModel?: string systemDefaultModel?: string + availableModels?: Set } ): { config: CategoryConfig; promptAppend: string; model: string | undefined } | null { - const { userCategories, inheritedModel, systemDefaultModel } = options + const { userCategories, inheritedModel, systemDefaultModel, availableModels } = options + + // Check if category requires a specific model + const categoryReq = CATEGORY_MODEL_REQUIREMENTS[categoryName] + if (categoryReq?.requiresModel && availableModels) { + if (!isModelAvailable(categoryReq.requiresModel, availableModels)) { + log(`[resolveCategoryConfig] Category ${categoryName} requires ${categoryReq.requiresModel} but not available`) + return null + } + } + const defaultConfig = DEFAULT_CATEGORIES[categoryName] const userConfig = userCategories?.[categoryName] const defaultPromptAppend = CATEGORY_PROMPT_APPENDS[categoryName] ?? "" @@ -522,11 +533,12 @@ To continue this session: session_id="${args.session_id}"` connectedProviders: connectedProviders ?? undefined }) - const resolved = resolveCategoryConfig(args.category, { - userCategories, - inheritedModel, - systemDefaultModel, - }) + const resolved = resolveCategoryConfig(args.category, { + userCategories, + inheritedModel, + systemDefaultModel, + availableModels, + }) if (!resolved) { return `Unknown category: "${args.category}". Available: ${Object.keys({ ...DEFAULT_CATEGORIES, ...userCategories }).join(", ")}` }