From 312eedfd8dd7c7d1cfaa54e190dfab0689258300 Mon Sep 17 00:00:00 2001 From: ismeth Date: Fri, 20 Feb 2026 22:09:28 +0100 Subject: [PATCH] fix(tests): update snapshots and positional arg indices for athena/council-member params - Regenerate model-fallback snapshots to include athena agent config - Fix createBuiltinAgents positional arg index for disableOmoEnv (shifted from index 12 to 13 by new councilConfig param) - Fix utils.test.ts, config-handler.test.ts arg positions --- src/agents/utils.test.ts | 4 + .../__snapshots__/model-fallback.test.ts.snap | 141 ------------------ src/plugin-handlers/config-handler.test.ts | 4 +- 3 files changed, 6 insertions(+), 143 deletions(-) diff --git a/src/agents/utils.test.ts b/src/agents/utils.test.ts index dbcfb7d9..7626e9be 100644 --- a/src/agents/utils.test.ts +++ b/src/agents/utils.test.ts @@ -753,6 +753,7 @@ describe("Hephaestus environment context toggle", () => { undefined, undefined, undefined, + undefined, disableFlag ) } @@ -812,6 +813,7 @@ describe("Sisyphus and Librarian environment context toggle", () => { undefined, undefined, undefined, + undefined, disableFlag ) } @@ -871,6 +873,7 @@ describe("Atlas is unaffected by environment context toggle", () => { undefined, undefined, undefined, + undefined, false ) @@ -887,6 +890,7 @@ describe("Atlas is unaffected by environment context toggle", () => { undefined, undefined, undefined, + undefined, true ) diff --git a/src/cli/__snapshots__/model-fallback.test.ts.snap b/src/cli/__snapshots__/model-fallback.test.ts.snap index 20d2248e..a9451a1c 100644 --- a/src/cli/__snapshots__/model-fallback.test.ts.snap +++ b/src/cli/__snapshots__/model-fallback.test.ts.snap @@ -4,15 +4,9 @@ exports[`generateModelConfig no providers available returns ULTIMATE_FALLBACK fo { "$schema": "https://raw.githubusercontent.com/code-yeongyu/oh-my-opencode/master/assets/oh-my-opencode.schema.json", "agents": { - "athena": { - "model": "opencode/big-pickle", - }, "atlas": { "model": "opencode/glm-4.7-free", }, - "council-member": { - "model": "opencode/big-pickle", - }, "explore": { "model": "opencode/glm-4.7-free", }, @@ -71,16 +65,9 @@ exports[`generateModelConfig single native provider uses Claude models when only { "$schema": "https://raw.githubusercontent.com/code-yeongyu/oh-my-opencode/master/assets/oh-my-opencode.schema.json", "agents": { - "athena": { - "model": "anthropic/claude-opus-4-6", - "variant": "max", - }, "atlas": { "model": "anthropic/claude-sonnet-4-5", }, - "council-member": { - "model": "opencode/big-pickle", - }, "explore": { "model": "anthropic/claude-haiku-4-5", }, @@ -140,16 +127,9 @@ exports[`generateModelConfig single native provider uses Claude models with isMa { "$schema": "https://raw.githubusercontent.com/code-yeongyu/oh-my-opencode/master/assets/oh-my-opencode.schema.json", "agents": { - "athena": { - "model": "anthropic/claude-opus-4-6", - "variant": "max", - }, "atlas": { "model": "anthropic/claude-sonnet-4-5", }, - "council-member": { - "model": "opencode/big-pickle", - }, "explore": { "model": "anthropic/claude-haiku-4-5", }, @@ -210,16 +190,9 @@ exports[`generateModelConfig single native provider uses OpenAI models when only { "$schema": "https://raw.githubusercontent.com/code-yeongyu/oh-my-opencode/master/assets/oh-my-opencode.schema.json", "agents": { - "athena": { - "model": "openai/gpt-5.2", - "variant": "high", - }, "atlas": { "model": "openai/gpt-5.2", }, - "council-member": { - "model": "opencode/big-pickle", - }, "explore": { "model": "opencode/gpt-5-nano", }, @@ -284,16 +257,9 @@ exports[`generateModelConfig single native provider uses OpenAI models with isMa { "$schema": "https://raw.githubusercontent.com/code-yeongyu/oh-my-opencode/master/assets/oh-my-opencode.schema.json", "agents": { - "athena": { - "model": "openai/gpt-5.2", - "variant": "high", - }, "atlas": { "model": "openai/gpt-5.2", }, - "council-member": { - "model": "opencode/big-pickle", - }, "explore": { "model": "opencode/gpt-5-nano", }, @@ -358,16 +324,9 @@ exports[`generateModelConfig single native provider uses Gemini models when only { "$schema": "https://raw.githubusercontent.com/code-yeongyu/oh-my-opencode/master/assets/oh-my-opencode.schema.json", "agents": { - "athena": { - "model": "google/gemini-3-pro", - "variant": "high", - }, "atlas": { "model": "google/gemini-3-pro-preview", }, - "council-member": { - "model": "opencode/big-pickle", - }, "explore": { "model": "opencode/gpt-5-nano", }, @@ -426,16 +385,9 @@ exports[`generateModelConfig single native provider uses Gemini models with isMa { "$schema": "https://raw.githubusercontent.com/code-yeongyu/oh-my-opencode/master/assets/oh-my-opencode.schema.json", "agents": { - "athena": { - "model": "google/gemini-3-pro", - "variant": "high", - }, "atlas": { "model": "google/gemini-3-pro-preview", }, - "council-member": { - "model": "opencode/big-pickle", - }, "explore": { "model": "opencode/gpt-5-nano", }, @@ -511,15 +463,10 @@ exports[`generateModelConfig all native providers uses preferred models from fal }, ], }, - "model": "anthropic/claude-opus-4-6", - "variant": "max", }, "atlas": { "model": "anthropic/claude-sonnet-4-5", }, - "council-member": { - "model": "opencode/big-pickle", - }, "explore": { "model": "anthropic/claude-haiku-4-5", }, @@ -608,15 +555,10 @@ exports[`generateModelConfig all native providers uses preferred models with isM }, ], }, - "model": "anthropic/claude-opus-4-6", - "variant": "max", }, "atlas": { "model": "anthropic/claude-sonnet-4-5", }, - "council-member": { - "model": "opencode/big-pickle", - }, "explore": { "model": "anthropic/claude-haiku-4-5", }, @@ -689,16 +631,9 @@ exports[`generateModelConfig fallback providers uses OpenCode Zen models when on { "$schema": "https://raw.githubusercontent.com/code-yeongyu/oh-my-opencode/master/assets/oh-my-opencode.schema.json", "agents": { - "athena": { - "model": "opencode/claude-opus-4-6", - "variant": "max", - }, "atlas": { "model": "opencode/kimi-k2.5-free", }, - "council-member": { - "model": "opencode/gpt-5-nano", - }, "explore": { "model": "opencode/claude-haiku-4-5", }, @@ -770,16 +705,9 @@ exports[`generateModelConfig fallback providers uses OpenCode Zen models with is { "$schema": "https://raw.githubusercontent.com/code-yeongyu/oh-my-opencode/master/assets/oh-my-opencode.schema.json", "agents": { - "athena": { - "model": "opencode/claude-opus-4-6", - "variant": "max", - }, "atlas": { "model": "opencode/kimi-k2.5-free", }, - "council-member": { - "model": "opencode/gpt-5-nano", - }, "explore": { "model": "opencode/claude-haiku-4-5", }, @@ -852,16 +780,9 @@ exports[`generateModelConfig fallback providers uses GitHub Copilot models when { "$schema": "https://raw.githubusercontent.com/code-yeongyu/oh-my-opencode/master/assets/oh-my-opencode.schema.json", "agents": { - "athena": { - "model": "github-copilot/claude-opus-4.6", - "variant": "max", - }, "atlas": { "model": "github-copilot/claude-sonnet-4.5", }, - "council-member": { - "model": "opencode/big-pickle", - }, "explore": { "model": "github-copilot/gpt-5-mini", }, @@ -933,16 +854,9 @@ exports[`generateModelConfig fallback providers uses GitHub Copilot models with { "$schema": "https://raw.githubusercontent.com/code-yeongyu/oh-my-opencode/master/assets/oh-my-opencode.schema.json", "agents": { - "athena": { - "model": "github-copilot/claude-opus-4.6", - "variant": "max", - }, "atlas": { "model": "github-copilot/claude-sonnet-4.5", }, - "council-member": { - "model": "opencode/big-pickle", - }, "explore": { "model": "github-copilot/gpt-5-mini", }, @@ -1015,15 +929,9 @@ exports[`generateModelConfig fallback providers uses ZAI model for librarian whe { "$schema": "https://raw.githubusercontent.com/code-yeongyu/oh-my-opencode/master/assets/oh-my-opencode.schema.json", "agents": { - "athena": { - "model": "zai-coding-plan/glm-4.7", - }, "atlas": { "model": "opencode/glm-4.7-free", }, - "council-member": { - "model": "opencode/big-pickle", - }, "explore": { "model": "opencode/gpt-5-nano", }, @@ -1076,15 +984,9 @@ exports[`generateModelConfig fallback providers uses ZAI model for librarian wit { "$schema": "https://raw.githubusercontent.com/code-yeongyu/oh-my-opencode/master/assets/oh-my-opencode.schema.json", "agents": { - "athena": { - "model": "zai-coding-plan/glm-4.7", - }, "atlas": { "model": "opencode/glm-4.7-free", }, - "council-member": { - "model": "opencode/big-pickle", - }, "explore": { "model": "opencode/gpt-5-nano", }, @@ -1137,16 +1039,9 @@ exports[`generateModelConfig mixed provider scenarios uses Claude + OpenCode Zen { "$schema": "https://raw.githubusercontent.com/code-yeongyu/oh-my-opencode/master/assets/oh-my-opencode.schema.json", "agents": { - "athena": { - "model": "anthropic/claude-opus-4-6", - "variant": "max", - }, "atlas": { "model": "opencode/kimi-k2.5-free", }, - "council-member": { - "model": "opencode/gpt-5-nano", - }, "explore": { "model": "anthropic/claude-haiku-4-5", }, @@ -1218,16 +1113,9 @@ exports[`generateModelConfig mixed provider scenarios uses OpenAI + Copilot comb { "$schema": "https://raw.githubusercontent.com/code-yeongyu/oh-my-opencode/master/assets/oh-my-opencode.schema.json", "agents": { - "athena": { - "model": "github-copilot/claude-opus-4.6", - "variant": "max", - }, "atlas": { "model": "github-copilot/claude-sonnet-4.5", }, - "council-member": { - "model": "opencode/big-pickle", - }, "explore": { "model": "github-copilot/gpt-5-mini", }, @@ -1299,16 +1187,9 @@ exports[`generateModelConfig mixed provider scenarios uses Claude + ZAI combinat { "$schema": "https://raw.githubusercontent.com/code-yeongyu/oh-my-opencode/master/assets/oh-my-opencode.schema.json", "agents": { - "athena": { - "model": "anthropic/claude-opus-4-6", - "variant": "max", - }, "atlas": { "model": "anthropic/claude-sonnet-4-5", }, - "council-member": { - "model": "opencode/big-pickle", - }, "explore": { "model": "anthropic/claude-haiku-4-5", }, @@ -1380,15 +1261,10 @@ exports[`generateModelConfig mixed provider scenarios uses Gemini + Claude combi }, ], }, - "model": "anthropic/claude-opus-4-6", - "variant": "max", }, "atlas": { "model": "anthropic/claude-sonnet-4-5", }, - "council-member": { - "model": "opencode/big-pickle", - }, "explore": { "model": "anthropic/claude-haiku-4-5", }, @@ -1452,16 +1328,9 @@ exports[`generateModelConfig mixed provider scenarios uses all fallback provider { "$schema": "https://raw.githubusercontent.com/code-yeongyu/oh-my-opencode/master/assets/oh-my-opencode.schema.json", "agents": { - "athena": { - "model": "github-copilot/claude-opus-4.6", - "variant": "max", - }, "atlas": { "model": "opencode/kimi-k2.5-free", }, - "council-member": { - "model": "opencode/gpt-5-nano", - }, "explore": { "model": "opencode/claude-haiku-4-5", }, @@ -1550,15 +1419,10 @@ exports[`generateModelConfig mixed provider scenarios uses all providers togethe }, ], }, - "model": "anthropic/claude-opus-4-6", - "variant": "max", }, "atlas": { "model": "opencode/kimi-k2.5-free", }, - "council-member": { - "model": "opencode/gpt-5-nano", - }, "explore": { "model": "anthropic/claude-haiku-4-5", }, @@ -1647,15 +1511,10 @@ exports[`generateModelConfig mixed provider scenarios uses all providers with is }, ], }, - "model": "anthropic/claude-opus-4-6", - "variant": "max", }, "atlas": { "model": "opencode/kimi-k2.5-free", }, - "council-member": { - "model": "opencode/gpt-5-nano", - }, "explore": { "model": "anthropic/claude-haiku-4-5", }, diff --git a/src/plugin-handlers/config-handler.test.ts b/src/plugin-handlers/config-handler.test.ts index 875a8cee..2d2f1a21 100644 --- a/src/plugin-handlers/config-handler.test.ts +++ b/src/plugin-handlers/config-handler.test.ts @@ -1310,7 +1310,7 @@ describe("disable_omo_env pass-through", () => { const lastCall = createBuiltinAgentsMock.mock.calls[createBuiltinAgentsMock.mock.calls.length - 1] expect(lastCall).toBeDefined() - expect(lastCall?.[12]).toBe(true) + expect(lastCall?.[13]).toBe(true) }) test("passes disable_omo_env=false to createBuiltinAgents when omitted", async () => { @@ -1344,6 +1344,6 @@ describe("disable_omo_env pass-through", () => { const lastCall = createBuiltinAgentsMock.mock.calls[createBuiltinAgentsMock.mock.calls.length - 1] expect(lastCall).toBeDefined() - expect(lastCall?.[12]).toBe(false) + expect(lastCall?.[13]).toBe(false) }) })