feat(hooks): add no-hephaestus-non-gpt hook to enforce GPT-only for Hephaestus
This commit is contained in:
parent
ac1eb30fda
commit
3dba1c49d4
@ -38,6 +38,7 @@ export const HookNameSchema = z.enum([
|
|||||||
"prometheus-md-only",
|
"prometheus-md-only",
|
||||||
"sisyphus-junior-notepad",
|
"sisyphus-junior-notepad",
|
||||||
"no-sisyphus-gpt",
|
"no-sisyphus-gpt",
|
||||||
|
"no-hephaestus-non-gpt",
|
||||||
"start-work",
|
"start-work",
|
||||||
"atlas",
|
"atlas",
|
||||||
"unstable-agent-babysitter",
|
"unstable-agent-babysitter",
|
||||||
|
|||||||
@ -28,6 +28,7 @@ export { createThinkingBlockValidatorHook } from "./thinking-block-validator";
|
|||||||
export { createCategorySkillReminderHook } from "./category-skill-reminder";
|
export { createCategorySkillReminderHook } from "./category-skill-reminder";
|
||||||
export { createRalphLoopHook, type RalphLoopHook } from "./ralph-loop";
|
export { createRalphLoopHook, type RalphLoopHook } from "./ralph-loop";
|
||||||
export { createNoSisyphusGptHook } from "./no-sisyphus-gpt";
|
export { createNoSisyphusGptHook } from "./no-sisyphus-gpt";
|
||||||
|
export { createNoHephaestusNonGptHook } from "./no-hephaestus-non-gpt";
|
||||||
export { createAutoSlashCommandHook } from "./auto-slash-command";
|
export { createAutoSlashCommandHook } from "./auto-slash-command";
|
||||||
export { createEditErrorRecoveryHook } from "./edit-error-recovery";
|
export { createEditErrorRecoveryHook } from "./edit-error-recovery";
|
||||||
export { createJsonErrorRecoveryHook } from "./json-error-recovery";
|
export { createJsonErrorRecoveryHook } from "./json-error-recovery";
|
||||||
|
|||||||
54
src/hooks/no-hephaestus-non-gpt/hook.ts
Normal file
54
src/hooks/no-hephaestus-non-gpt/hook.ts
Normal file
@ -0,0 +1,54 @@
|
|||||||
|
import type { PluginInput } from "@opencode-ai/plugin"
|
||||||
|
import { isGptModel } from "../../agents/types"
|
||||||
|
import { getSessionAgent, updateSessionAgent } from "../../features/claude-code-session-state"
|
||||||
|
import { log } from "../../shared"
|
||||||
|
import { getAgentConfigKey, getAgentDisplayName } from "../../shared/agent-display-names"
|
||||||
|
|
||||||
|
const TOAST_TITLE = "NEVER Use Hephaestus with Non-GPT"
|
||||||
|
const TOAST_MESSAGE = [
|
||||||
|
"Hephaestus is designed exclusively for GPT models.",
|
||||||
|
"Hephaestus + non-GPT performs worse than vanilla Sisyphus.",
|
||||||
|
"For Claude/Kimi/GLM models, always use Sisyphus.",
|
||||||
|
].join("\n")
|
||||||
|
const SISYPHUS_DISPLAY = getAgentDisplayName("sisyphus")
|
||||||
|
|
||||||
|
function showToast(ctx: PluginInput, sessionID: string): void {
|
||||||
|
ctx.client.tui.showToast({
|
||||||
|
body: {
|
||||||
|
title: TOAST_TITLE,
|
||||||
|
message: TOAST_MESSAGE,
|
||||||
|
variant: "error",
|
||||||
|
duration: 10000,
|
||||||
|
},
|
||||||
|
}).catch((error) => {
|
||||||
|
log("[no-hephaestus-non-gpt] Failed to show toast", {
|
||||||
|
sessionID,
|
||||||
|
error,
|
||||||
|
})
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
export function createNoHephaestusNonGptHook(ctx: PluginInput) {
|
||||||
|
return {
|
||||||
|
"chat.message": async (input: {
|
||||||
|
sessionID: string
|
||||||
|
agent?: string
|
||||||
|
model?: { providerID: string; modelID: string }
|
||||||
|
}, output?: {
|
||||||
|
message?: { agent?: string; [key: string]: unknown }
|
||||||
|
}): Promise<void> => {
|
||||||
|
const rawAgent = input.agent ?? getSessionAgent(input.sessionID) ?? ""
|
||||||
|
const agentKey = getAgentConfigKey(rawAgent)
|
||||||
|
const modelID = input.model?.modelID
|
||||||
|
|
||||||
|
if (agentKey === "hephaestus" && modelID && !isGptModel(modelID)) {
|
||||||
|
showToast(ctx, input.sessionID)
|
||||||
|
input.agent = SISYPHUS_DISPLAY
|
||||||
|
if (output?.message) {
|
||||||
|
output.message.agent = SISYPHUS_DISPLAY
|
||||||
|
}
|
||||||
|
updateSessionAgent(input.sessionID, SISYPHUS_DISPLAY)
|
||||||
|
}
|
||||||
|
},
|
||||||
|
}
|
||||||
|
}
|
||||||
115
src/hooks/no-hephaestus-non-gpt/index.test.ts
Normal file
115
src/hooks/no-hephaestus-non-gpt/index.test.ts
Normal file
@ -0,0 +1,115 @@
|
|||||||
|
import { describe, expect, spyOn, test } from "bun:test"
|
||||||
|
import { _resetForTesting, updateSessionAgent } from "../../features/claude-code-session-state"
|
||||||
|
import { getAgentDisplayName } from "../../shared/agent-display-names"
|
||||||
|
import { createNoHephaestusNonGptHook } from "./index"
|
||||||
|
|
||||||
|
const HEPHAESTUS_DISPLAY = getAgentDisplayName("hephaestus")
|
||||||
|
const SISYPHUS_DISPLAY = getAgentDisplayName("sisyphus")
|
||||||
|
|
||||||
|
function createOutput() {
|
||||||
|
return {
|
||||||
|
message: {},
|
||||||
|
parts: [],
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
describe("no-hephaestus-non-gpt hook", () => {
|
||||||
|
test("shows toast on every chat.message when hephaestus uses non-gpt model", async () => {
|
||||||
|
// given - hephaestus with claude model
|
||||||
|
const showToast = spyOn({ fn: async () => ({}) }, "fn")
|
||||||
|
const hook = createNoHephaestusNonGptHook({
|
||||||
|
client: { tui: { showToast } },
|
||||||
|
} as any)
|
||||||
|
|
||||||
|
const output1 = createOutput()
|
||||||
|
const output2 = createOutput()
|
||||||
|
|
||||||
|
// when - chat.message is called repeatedly
|
||||||
|
await hook["chat.message"]?.({
|
||||||
|
sessionID: "ses_1",
|
||||||
|
agent: HEPHAESTUS_DISPLAY,
|
||||||
|
model: { providerID: "anthropic", modelID: "claude-opus-4-6" },
|
||||||
|
}, output1)
|
||||||
|
await hook["chat.message"]?.({
|
||||||
|
sessionID: "ses_1",
|
||||||
|
agent: HEPHAESTUS_DISPLAY,
|
||||||
|
model: { providerID: "anthropic", modelID: "claude-opus-4-6" },
|
||||||
|
}, output2)
|
||||||
|
|
||||||
|
// then - toast is shown and agent is switched to sisyphus
|
||||||
|
expect(showToast).toHaveBeenCalledTimes(2)
|
||||||
|
expect(output1.message.agent).toBe(SISYPHUS_DISPLAY)
|
||||||
|
expect(output2.message.agent).toBe(SISYPHUS_DISPLAY)
|
||||||
|
expect(showToast.mock.calls[0]?.[0]).toMatchObject({
|
||||||
|
body: {
|
||||||
|
title: "NEVER Use Hephaestus with Non-GPT",
|
||||||
|
message: expect.stringContaining("For Claude/Kimi/GLM models, always use Sisyphus."),
|
||||||
|
variant: "error",
|
||||||
|
},
|
||||||
|
})
|
||||||
|
})
|
||||||
|
|
||||||
|
test("does not show toast when hephaestus uses gpt model", async () => {
|
||||||
|
// given - hephaestus with gpt model
|
||||||
|
const showToast = spyOn({ fn: async () => ({}) }, "fn")
|
||||||
|
const hook = createNoHephaestusNonGptHook({
|
||||||
|
client: { tui: { showToast } },
|
||||||
|
} as any)
|
||||||
|
|
||||||
|
const output = createOutput()
|
||||||
|
|
||||||
|
// when - chat.message runs
|
||||||
|
await hook["chat.message"]?.({
|
||||||
|
sessionID: "ses_2",
|
||||||
|
agent: HEPHAESTUS_DISPLAY,
|
||||||
|
model: { providerID: "openai", modelID: "gpt-5.3-codex" },
|
||||||
|
}, output)
|
||||||
|
|
||||||
|
// then - no toast, agent unchanged
|
||||||
|
expect(showToast).toHaveBeenCalledTimes(0)
|
||||||
|
expect(output.message.agent).toBeUndefined()
|
||||||
|
})
|
||||||
|
|
||||||
|
test("does not show toast for non-hephaestus agent", async () => {
|
||||||
|
// given - sisyphus with claude model (non-gpt)
|
||||||
|
const showToast = spyOn({ fn: async () => ({}) }, "fn")
|
||||||
|
const hook = createNoHephaestusNonGptHook({
|
||||||
|
client: { tui: { showToast } },
|
||||||
|
} as any)
|
||||||
|
|
||||||
|
const output = createOutput()
|
||||||
|
|
||||||
|
// when - chat.message runs
|
||||||
|
await hook["chat.message"]?.({
|
||||||
|
sessionID: "ses_3",
|
||||||
|
agent: SISYPHUS_DISPLAY,
|
||||||
|
model: { providerID: "anthropic", modelID: "claude-opus-4-6" },
|
||||||
|
}, output)
|
||||||
|
|
||||||
|
// then - no toast
|
||||||
|
expect(showToast).toHaveBeenCalledTimes(0)
|
||||||
|
expect(output.message.agent).toBeUndefined()
|
||||||
|
})
|
||||||
|
|
||||||
|
test("uses session agent fallback when input agent is missing", async () => {
|
||||||
|
// given - session agent saved as hephaestus
|
||||||
|
_resetForTesting()
|
||||||
|
updateSessionAgent("ses_4", HEPHAESTUS_DISPLAY)
|
||||||
|
const showToast = spyOn({ fn: async () => ({}) }, "fn")
|
||||||
|
const hook = createNoHephaestusNonGptHook({
|
||||||
|
client: { tui: { showToast } },
|
||||||
|
} as any)
|
||||||
|
|
||||||
|
const output = createOutput()
|
||||||
|
|
||||||
|
// when - chat.message runs without input.agent
|
||||||
|
await hook["chat.message"]?.({
|
||||||
|
sessionID: "ses_4",
|
||||||
|
model: { providerID: "anthropic", modelID: "claude-opus-4-6" },
|
||||||
|
}, output)
|
||||||
|
|
||||||
|
// then - toast shown via session-agent fallback, switched to sisyphus
|
||||||
|
expect(showToast).toHaveBeenCalledTimes(1)
|
||||||
|
expect(output.message.agent).toBe(SISYPHUS_DISPLAY)
|
||||||
|
})
|
||||||
|
})
|
||||||
1
src/hooks/no-hephaestus-non-gpt/index.ts
Normal file
1
src/hooks/no-hephaestus-non-gpt/index.ts
Normal file
@ -0,0 +1 @@
|
|||||||
|
export { createNoHephaestusNonGptHook } from "./hook"
|
||||||
@ -83,6 +83,7 @@ export function createChatMessageHandler(args: {
|
|||||||
await hooks.claudeCodeHooks?.["chat.message"]?.(input, output)
|
await hooks.claudeCodeHooks?.["chat.message"]?.(input, output)
|
||||||
await hooks.autoSlashCommand?.["chat.message"]?.(input, output)
|
await hooks.autoSlashCommand?.["chat.message"]?.(input, output)
|
||||||
await hooks.noSisyphusGpt?.["chat.message"]?.(input, output)
|
await hooks.noSisyphusGpt?.["chat.message"]?.(input, output)
|
||||||
|
await hooks.noHephaestusNonGpt?.["chat.message"]?.(input, output)
|
||||||
if (hooks.startWork && isStartWorkHookOutput(output)) {
|
if (hooks.startWork && isStartWorkHookOutput(output)) {
|
||||||
await hooks.startWork["chat.message"]?.(input, output)
|
await hooks.startWork["chat.message"]?.(input, output)
|
||||||
}
|
}
|
||||||
|
|||||||
@ -21,6 +21,7 @@ import {
|
|||||||
createPrometheusMdOnlyHook,
|
createPrometheusMdOnlyHook,
|
||||||
createSisyphusJuniorNotepadHook,
|
createSisyphusJuniorNotepadHook,
|
||||||
createNoSisyphusGptHook,
|
createNoSisyphusGptHook,
|
||||||
|
createNoHephaestusNonGptHook,
|
||||||
createQuestionLabelTruncatorHook,
|
createQuestionLabelTruncatorHook,
|
||||||
createPreemptiveCompactionHook,
|
createPreemptiveCompactionHook,
|
||||||
} from "../../hooks"
|
} from "../../hooks"
|
||||||
@ -52,6 +53,7 @@ export type SessionHooks = {
|
|||||||
prometheusMdOnly: ReturnType<typeof createPrometheusMdOnlyHook> | null
|
prometheusMdOnly: ReturnType<typeof createPrometheusMdOnlyHook> | null
|
||||||
sisyphusJuniorNotepad: ReturnType<typeof createSisyphusJuniorNotepadHook> | null
|
sisyphusJuniorNotepad: ReturnType<typeof createSisyphusJuniorNotepadHook> | null
|
||||||
noSisyphusGpt: ReturnType<typeof createNoSisyphusGptHook> | null
|
noSisyphusGpt: ReturnType<typeof createNoSisyphusGptHook> | null
|
||||||
|
noHephaestusNonGpt: ReturnType<typeof createNoHephaestusNonGptHook> | null
|
||||||
questionLabelTruncator: ReturnType<typeof createQuestionLabelTruncatorHook>
|
questionLabelTruncator: ReturnType<typeof createQuestionLabelTruncatorHook>
|
||||||
taskResumeInfo: ReturnType<typeof createTaskResumeInfoHook>
|
taskResumeInfo: ReturnType<typeof createTaskResumeInfoHook>
|
||||||
anthropicEffort: ReturnType<typeof createAnthropicEffortHook> | null
|
anthropicEffort: ReturnType<typeof createAnthropicEffortHook> | null
|
||||||
@ -162,6 +164,10 @@ export function createSessionHooks(args: {
|
|||||||
? safeHook("no-sisyphus-gpt", () => createNoSisyphusGptHook(ctx))
|
? safeHook("no-sisyphus-gpt", () => createNoSisyphusGptHook(ctx))
|
||||||
: null
|
: null
|
||||||
|
|
||||||
|
const noHephaestusNonGpt = isHookEnabled("no-hephaestus-non-gpt")
|
||||||
|
? safeHook("no-hephaestus-non-gpt", () => createNoHephaestusNonGptHook(ctx))
|
||||||
|
: null
|
||||||
|
|
||||||
const questionLabelTruncator = createQuestionLabelTruncatorHook()
|
const questionLabelTruncator = createQuestionLabelTruncatorHook()
|
||||||
const taskResumeInfo = createTaskResumeInfoHook()
|
const taskResumeInfo = createTaskResumeInfoHook()
|
||||||
|
|
||||||
@ -188,6 +194,7 @@ export function createSessionHooks(args: {
|
|||||||
prometheusMdOnly,
|
prometheusMdOnly,
|
||||||
sisyphusJuniorNotepad,
|
sisyphusJuniorNotepad,
|
||||||
noSisyphusGpt,
|
noSisyphusGpt,
|
||||||
|
noHephaestusNonGpt,
|
||||||
questionLabelTruncator,
|
questionLabelTruncator,
|
||||||
taskResumeInfo,
|
taskResumeInfo,
|
||||||
anthropicEffort,
|
anthropicEffort,
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user