elias/oh-my-opencode
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolve ultrabrain review findings

Browse Source 
- Remove runtime-fallback gate from session.status retry handler — runtime-fallback
  has no session.status handler, so gating it causes retry signals to be silently dropped
- Fix background_output full_session arg description: default is true, not false
This commit is contained in:
YeonGyu-Kim 2026-02-21 16:40:15 +09:00
parent fe415319e5
commit 66aebb1b59
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugin/event.ts
View File

@ -333,7 +333,7 @@ export function createEventHandler(args: {
| { type?: string; attempt?: number; message?: string; next?: number } | { type?: string; attempt?: number; message?: string; next?: number }
| undefined | undefined
if (sessionID && status?.type === "retry" && !isRuntimeFallbackEnabled) { if (sessionID && status?.type === "retry") {
try { try {
const retryMessage = typeof status.message === "string" ? status.message : "" const retryMessage = typeof status.message === "string" ? status.message : ""
const retryKey = `${status.attempt ?? "?"}:${status.next ?? "?"}:${retryMessage}` const retryKey = `${status.attempt ?? "?"}:${status.next ?? "?"}:${retryMessage}`

2
src/tools/background-task/create-background-output.ts
View File

@ -45,7 +45,7 @@ export function createBackgroundOutput(manager: BackgroundOutputManager, client:
"Wait for completion (default: false). System notifies when done, so blocking is rarely needed." "Wait for completion (default: false). System notifies when done, so blocking is rarely needed."
), ),
timeout: tool.schema.number().optional().describe("Max wait time in ms (default: 60000, max: 600000)"), timeout: tool.schema.number().optional().describe("Max wait time in ms (default: 60000, max: 600000)"),
full_session: tool.schema.boolean().optional().describe("Return full session messages with filters (default: false)"), full_session: tool.schema.boolean().optional().describe("Return full session messages with filters (default: true)"),
include_thinking: tool.schema.boolean().optional().describe("Include thinking/reasoning parts in full_session output (default: false)"), include_thinking: tool.schema.boolean().optional().describe("Include thinking/reasoning parts in full_session output (default: false)"),
message_limit: tool.schema.number().optional().describe("Max messages to return (capped at 100)"), message_limit: tool.schema.number().optional().describe("Max messages to return (capped at 100)"),
since_message_id: tool.schema.string().optional().describe("Return messages after this message ID (exclusive)"), since_message_id: tool.schema.string().optional().describe("Return messages after this message ID (exclusive)"),