refactor: consolidate duplicated Promise.all dual reads into resolveMessageContext utility

This commit is contained in:
YeonGyu-Kim 2026-02-16 18:20:27 +09:00
parent 1a6810535c
commit 8e0d1341b6
5 changed files with 25 additions and 68 deletions

View File

@ -4,6 +4,7 @@ export {
findFirstMessageWithAgent, findFirstMessageWithAgent,
findNearestMessageWithFieldsFromSDK, findNearestMessageWithFieldsFromSDK,
findFirstMessageWithAgentFromSDK, findFirstMessageWithAgentFromSDK,
resolveMessageContext,
} from "./injector" } from "./injector"
export type { StoredMessage } from "./injector" export type { StoredMessage } from "./injector"
export type { MessageMeta, OriginalMessageContext, TextPart, ToolPermission } from "./types" export type { MessageMeta, OriginalMessageContext, TextPart, ToolPermission } from "./types"

View File

@ -2,18 +2,12 @@ import { tool, type PluginInput, type ToolDefinition } from "@opencode-ai/plugin
import type { BackgroundManager } from "../../features/background-agent" import type { BackgroundManager } from "../../features/background-agent"
import type { BackgroundTaskArgs } from "./types" import type { BackgroundTaskArgs } from "./types"
import { BACKGROUND_TASK_DESCRIPTION } from "./constants" import { BACKGROUND_TASK_DESCRIPTION } from "./constants"
import { import { resolveMessageContext } from "../../features/hook-message-injector"
findFirstMessageWithAgent,
findFirstMessageWithAgentFromSDK,
findNearestMessageWithFields,
findNearestMessageWithFieldsFromSDK,
} from "../../features/hook-message-injector"
import { getSessionAgent } from "../../features/claude-code-session-state" import { getSessionAgent } from "../../features/claude-code-session-state"
import { storeToolMetadata } from "../../features/tool-metadata-store" import { storeToolMetadata } from "../../features/tool-metadata-store"
import { log } from "../../shared/logger" import { log } from "../../shared/logger"
import { delay } from "./delay" import { delay } from "./delay"
import { getMessageDir } from "./message-dir" import { getMessageDir } from "./message-dir"
import { isSqliteBackend } from "../../shared/opencode-storage-detection"
type ToolContextWithMetadata = { type ToolContextWithMetadata = {
sessionID: string sessionID: string
@ -44,16 +38,11 @@ export function createBackgroundTask(
try { try {
const messageDir = getMessageDir(ctx.sessionID) const messageDir = getMessageDir(ctx.sessionID)
const { prevMessage, firstMessageAgent } = await resolveMessageContext(
const [prevMessage, firstMessageAgent] = isSqliteBackend() ctx.sessionID,
? await Promise.all([ client,
findNearestMessageWithFieldsFromSDK(client, ctx.sessionID), messageDir
findFirstMessageWithAgentFromSDK(client, ctx.sessionID), )
])
: [
messageDir ? findNearestMessageWithFields(messageDir) : null,
messageDir ? findFirstMessageWithAgent(messageDir) : null,
]
const sessionAgent = getSessionAgent(ctx.sessionID) const sessionAgent = getSessionAgent(ctx.sessionID)
const parentAgent = ctx.agent ?? sessionAgent ?? firstMessageAgent ?? prevMessage?.agent const parentAgent = ctx.agent ?? sessionAgent ?? firstMessageAgent ?? prevMessage?.agent

View File

@ -1,18 +1,12 @@
import type { BackgroundManager } from "../../features/background-agent" import type { BackgroundManager } from "../../features/background-agent"
import type { PluginInput } from "@opencode-ai/plugin" import type { PluginInput } from "@opencode-ai/plugin"
import { import { resolveMessageContext } from "../../features/hook-message-injector"
findFirstMessageWithAgent,
findFirstMessageWithAgentFromSDK,
findNearestMessageWithFields,
findNearestMessageWithFieldsFromSDK,
} from "../../features/hook-message-injector"
import { getSessionAgent } from "../../features/claude-code-session-state" import { getSessionAgent } from "../../features/claude-code-session-state"
import { log } from "../../shared" import { log } from "../../shared"
import type { CallOmoAgentArgs } from "./types" import type { CallOmoAgentArgs } from "./types"
import type { ToolContextWithMetadata } from "./tool-context-with-metadata" import type { ToolContextWithMetadata } from "./tool-context-with-metadata"
import { getMessageDir } from "./message-storage-directory" import { getMessageDir } from "./message-storage-directory"
import { getSessionTools } from "../../shared/session-tools-store" import { getSessionTools } from "../../shared/session-tools-store"
import { isSqliteBackend } from "../../shared/opencode-storage-detection"
export async function executeBackgroundAgent( export async function executeBackgroundAgent(
args: CallOmoAgentArgs, args: CallOmoAgentArgs,
@ -22,16 +16,11 @@ export async function executeBackgroundAgent(
): Promise<string> { ): Promise<string> {
try { try {
const messageDir = getMessageDir(toolContext.sessionID) const messageDir = getMessageDir(toolContext.sessionID)
const { prevMessage, firstMessageAgent } = await resolveMessageContext(
const [prevMessage, firstMessageAgent] = isSqliteBackend() toolContext.sessionID,
? await Promise.all([ client,
findNearestMessageWithFieldsFromSDK(client, toolContext.sessionID), messageDir
findFirstMessageWithAgentFromSDK(client, toolContext.sessionID), )
])
: [
messageDir ? findNearestMessageWithFields(messageDir) : null,
messageDir ? findFirstMessageWithAgent(messageDir) : null,
]
const sessionAgent = getSessionAgent(toolContext.sessionID) const sessionAgent = getSessionAgent(toolContext.sessionID)
const parentAgent = const parentAgent =

View File

@ -3,16 +3,10 @@ import type { BackgroundManager } from "../../features/background-agent"
import type { PluginInput } from "@opencode-ai/plugin" import type { PluginInput } from "@opencode-ai/plugin"
import { log } from "../../shared" import { log } from "../../shared"
import { consumeNewMessages } from "../../shared/session-cursor" import { consumeNewMessages } from "../../shared/session-cursor"
import { import { resolveMessageContext } from "../../features/hook-message-injector"
findFirstMessageWithAgent,
findFirstMessageWithAgentFromSDK,
findNearestMessageWithFields,
findNearestMessageWithFieldsFromSDK,
} from "../../features/hook-message-injector"
import { getSessionAgent } from "../../features/claude-code-session-state" import { getSessionAgent } from "../../features/claude-code-session-state"
import { getMessageDir } from "./message-dir" import { getMessageDir } from "./message-dir"
import { getSessionTools } from "../../shared/session-tools-store" import { getSessionTools } from "../../shared/session-tools-store"
import { isSqliteBackend } from "../../shared/opencode-storage-detection"
export async function executeBackground( export async function executeBackground(
args: CallOmoAgentArgs, args: CallOmoAgentArgs,
@ -28,16 +22,11 @@ export async function executeBackground(
): Promise<string> { ): Promise<string> {
try { try {
const messageDir = getMessageDir(toolContext.sessionID) const messageDir = getMessageDir(toolContext.sessionID)
const { prevMessage, firstMessageAgent } = await resolveMessageContext(
const [prevMessage, firstMessageAgent] = isSqliteBackend() toolContext.sessionID,
? await Promise.all([ client,
findNearestMessageWithFieldsFromSDK(client, toolContext.sessionID), messageDir
findFirstMessageWithAgentFromSDK(client, toolContext.sessionID), )
])
: [
messageDir ? findNearestMessageWithFields(messageDir) : null,
messageDir ? findFirstMessageWithAgent(messageDir) : null,
]
const sessionAgent = getSessionAgent(toolContext.sessionID) const sessionAgent = getSessionAgent(toolContext.sessionID)
const parentAgent = toolContext.agent ?? sessionAgent ?? firstMessageAgent ?? prevMessage?.agent const parentAgent = toolContext.agent ?? sessionAgent ?? firstMessageAgent ?? prevMessage?.agent

View File

@ -1,32 +1,21 @@
import type { ToolContextWithMetadata } from "./types" import type { ToolContextWithMetadata } from "./types"
import type { OpencodeClient } from "./types" import type { OpencodeClient } from "./types"
import type { ParentContext } from "./executor-types" import type { ParentContext } from "./executor-types"
import { import { resolveMessageContext } from "../../features/hook-message-injector"
findFirstMessageWithAgent,
findFirstMessageWithAgentFromSDK,
findNearestMessageWithFields,
findNearestMessageWithFieldsFromSDK,
} from "../../features/hook-message-injector"
import { getSessionAgent } from "../../features/claude-code-session-state" import { getSessionAgent } from "../../features/claude-code-session-state"
import { log } from "../../shared/logger" import { log } from "../../shared/logger"
import { getMessageDir } from "../../shared/opencode-message-dir" import { getMessageDir } from "../../shared/opencode-message-dir"
import { isSqliteBackend } from "../../shared/opencode-storage-detection"
export async function resolveParentContext( export async function resolveParentContext(
ctx: ToolContextWithMetadata, ctx: ToolContextWithMetadata,
client: OpencodeClient client: OpencodeClient
): Promise<ParentContext> { ): Promise<ParentContext> {
const messageDir = getMessageDir(ctx.sessionID) const messageDir = getMessageDir(ctx.sessionID)
const { prevMessage, firstMessageAgent } = await resolveMessageContext(
const [prevMessage, firstMessageAgent] = isSqliteBackend() ctx.sessionID,
? await Promise.all([ client,
findNearestMessageWithFieldsFromSDK(client, ctx.sessionID), messageDir
findFirstMessageWithAgentFromSDK(client, ctx.sessionID), )
])
: [
messageDir ? findNearestMessageWithFields(messageDir) : null,
messageDir ? findFirstMessageWithAgent(messageDir) : null,
]
const sessionAgent = getSessionAgent(ctx.sessionID) const sessionAgent = getSessionAgent(ctx.sessionID)
const parentAgent = ctx.agent ?? sessionAgent ?? firstMessageAgent ?? prevMessage?.agent const parentAgent = ctx.agent ?? sessionAgent ?? firstMessageAgent ?? prevMessage?.agent