elias/oh-my-opencode
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(look-at): stabilize image-converter tests across platforms

Browse Source
This commit is contained in:
YeonGyu-Kim 2026-03-03 00:47:21 +09:00
parent 4123148376
commit b5100d99df
1 changed files with 25 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
src/tools/look-at/image-converter.test.ts
View File

@ -18,6 +18,26 @@ mock.module("node:child_process", () => ({
const { convertImageToJpeg, cleanupConvertedImage } = await import("./image-converter") const { convertImageToJpeg, cleanupConvertedImage } = await import("./image-converter")
function writeConvertedOutput(command: string, args: string[]): void {
if (command === "sips") {
const outIndex = args.indexOf("--out")
const outputPath = outIndex >= 0 ? args[outIndex + 1] : undefined
if (outputPath) {
writeFileSync(outputPath, "jpeg")
}
return
}
if (command === "convert") {
writeFileSync(args[2], "jpeg")
return
}
if (command === "magick") {
writeFileSync(args[2], "jpeg")
}
}
function withMockPlatform<TValue>(platform: NodeJS.Platform, run: () => TValue): TValue { function withMockPlatform<TValue>(platform: NodeJS.Platform, run: () => TValue): TValue {
const originalPlatform = process.platform const originalPlatform = process.platform
Object.defineProperty(process, "platform", { Object.defineProperty(process, "platform", {
@ -47,13 +67,7 @@ describe("image-converter command execution safety", () => {
writeFileSync(inputPath, "fake-heic-data") writeFileSync(inputPath, "fake-heic-data")
execFileSyncMock.mockImplementation((command: string, args: string[]) => { execFileSyncMock.mockImplementation((command: string, args: string[]) => {
if (command === "sips") { writeConvertedOutput(command, args)
const outIndex = args.indexOf("--out")
const outputPath = outIndex >= 0 ? args[outIndex + 1] : undefined
if (outputPath) writeFileSync(outputPath, "jpeg")
} else if (command === "convert") {
writeFileSync(args[1], "jpeg")
}
return "" return ""
}) })
@ -65,9 +79,10 @@ describe("image-converter command execution safety", () => {
const [firstCommand, firstArgs] = execFileSyncMock.mock.calls[0] as [string, string[]] const [firstCommand, firstArgs] = execFileSyncMock.mock.calls[0] as [string, string[]]
expect(typeof firstCommand).toBe("string") expect(typeof firstCommand).toBe("string")
expect(Array.isArray(firstArgs)).toBe(true) expect(Array.isArray(firstArgs)).toBe(true)
expect(["sips", "convert", "magick"]).toContain(firstCommand)
expect(firstArgs).toContain("--") expect(firstArgs).toContain("--")
expect(firstArgs.indexOf("--") < firstArgs.indexOf(inputPath)).toBe(true)
expect(firstArgs).toContain(inputPath) expect(firstArgs).toContain(inputPath)
expect(firstArgs.indexOf("--") < firstArgs.indexOf(inputPath)).toBe(true)
expect(firstArgs.join(" ")).not.toContain(`\"${inputPath}\"`) expect(firstArgs.join(" ")).not.toContain(`\"${inputPath}\"`)
expect(existsSync(outputPath)).toBe(true) expect(existsSync(outputPath)).toBe(true)
@ -83,11 +98,7 @@ describe("image-converter command execution safety", () => {
writeFileSync(inputPath, "fake-heic-data") writeFileSync(inputPath, "fake-heic-data")
execFileSyncMock.mockImplementation((command: string, args: string[]) => { execFileSyncMock.mockImplementation((command: string, args: string[]) => {
if (command === "sips") { writeConvertedOutput(command, args)
const outIndex = args.indexOf("--out")
const outputPath = outIndex >= 0 ? args[outIndex + 1] : undefined
if (outputPath) writeFileSync(outputPath, "jpeg")
}
return "" return ""
}) })
@ -137,11 +148,7 @@ describe("image-converter command execution safety", () => {
writeFileSync(inputPath, "fake-heic-data") writeFileSync(inputPath, "fake-heic-data")
execFileSyncMock.mockImplementation((command: string, args: string[]) => { execFileSyncMock.mockImplementation((command: string, args: string[]) => {
if (command === "sips") { writeConvertedOutput(command, args)
const outIndex = args.indexOf("--out")
const outputPath = outIndex >= 0 ? args[outIndex + 1] : undefined
if (outputPath) writeFileSync(outputPath, "jpeg")
}
return "" return ""
}) })