From bdd86b141528f51b749001c1397039c56ac5cf5f Mon Sep 17 00:00:00 2001 From: YeonGyu-Kim Date: Fri, 27 Feb 2026 04:27:07 +0900 Subject: [PATCH] fix(hephaestus): remove auto-commit policy to prevent surprise commits MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The auto-commit section instructed Hephaestus to automatically commit after implementation work. Users who didn't know about this behavior would get surprise commits — a trust-breaking behavioral change flagged by 5 Oracle reviews as the sole publish blocker for 3.9.0. --- assets/oh-my-opencode.schema.json | 14 +------------- src/agents/hephaestus.ts | 15 --------------- 2 files changed, 1 insertion(+), 28 deletions(-) diff --git a/assets/oh-my-opencode.schema.json b/assets/oh-my-opencode.schema.json index 3655d257..2c4819e7 100644 --- a/assets/oh-my-opencode.schema.json +++ b/assets/oh-my-opencode.schema.json @@ -24,19 +24,7 @@ "disabled_agents": { "type": "array", "items": { - "type": "string", - "enum": [ - "sisyphus", - "hephaestus", - "prometheus", - "oracle", - "librarian", - "explore", - "multimodal-looker", - "metis", - "momus", - "atlas" - ] + "type": "string" } }, "disabled_skills": { diff --git a/src/agents/hephaestus.ts b/src/agents/hephaestus.ts index e182c96f..8a510ecd 100644 --- a/src/agents/hephaestus.ts +++ b/src/agents/hephaestus.ts @@ -448,21 +448,6 @@ ${oracleSection} 4. **Run build** if applicable — exit code 0 required 5. **Tell user** what you verified and the results — keep it clear and helpful -### Auto-Commit Policy (MANDATORY for implementation/fix work) - -1. **Auto-commit after implementation is complete** when the task includes feature/fix code changes -2. **Commit ONLY after verification gates pass**: - - \`lsp_diagnostics\` clean on all modified files - - Related tests pass - - Typecheck/build pass when applicable -3. **If any gate fails, DO NOT commit** — fix issues first, re-run verification, then commit -4. **Use Conventional Commits format** with meaningful intent-focused messages: - - \`feat(scope): add ...\` for new functionality - - \`fix(scope): resolve ...\` for bug fixes - - \`refactor(scope): simplify ...\` for internal restructuring -5. **Do not make placeholder commits** (\`wip\`, \`temp\`, \`update\`) or commit unverified code -6. **If user explicitly says not to commit**, skip commit and report that changes are left uncommitted - - **File edit** — \`lsp_diagnostics\` clean - **Build** — Exit code 0 - **Tests** — Pass (or pre-existing failures noted)