elias/oh-my-opencode
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(agents): remove duplicate remapped agent keys

Browse Source
This commit is contained in:
acamq 2026-02-26 15:58:02 -07:00
parent 21c249e8c8
commit d6dd54867a
No known key found for this signature in database
2 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/plugin-handlers/agent-key-remapper.test.ts
View File

@ -2,7 +2,7 @@ import { describe, it, expect } from "bun:test"
import { remapAgentKeysToDisplayNames } from "./agent-key-remapper" import { remapAgentKeysToDisplayNames } from "./agent-key-remapper"
describe("remapAgentKeysToDisplayNames", () => { describe("remapAgentKeysToDisplayNames", () => {
it("remaps known agent keys to display names while preserving original keys", () => { it("remaps known agent keys to display names", () => {
// given agents with lowercase keys // given agents with lowercase keys
const agents = { const agents = {
sisyphus: { prompt: "test", mode: "primary" }, sisyphus: { prompt: "test", mode: "primary" },
@ -12,11 +12,10 @@ describe("remapAgentKeysToDisplayNames", () => {
// when remapping // when remapping
const result = remapAgentKeysToDisplayNames(agents) const result = remapAgentKeysToDisplayNames(agents)
// then known agents get display name keys and original keys remain accessible // then known agents get display name keys only
expect(result["Sisyphus (Ultraworker)"]).toBeDefined() expect(result["Sisyphus (Ultraworker)"]).toBeDefined()
expect(result["oracle"]).toBeDefined() expect(result["oracle"]).toBeDefined()
expect(result["sisyphus"]).toBeDefined() expect(result["sisyphus"]).toBeUndefined()
expect(result["Sisyphus (Ultraworker)"]).toBe(result["sisyphus"])
}) })
it("preserves unknown agent keys unchanged", () => { it("preserves unknown agent keys unchanged", () => {
@ -32,7 +31,7 @@ describe("remapAgentKeysToDisplayNames", () => {
expect(result["custom-agent"]).toBeDefined() expect(result["custom-agent"]).toBeDefined()
}) })
it("remaps all core agents while preserving original keys", () => { it("remaps all core agents to display names", () => {
// given all core agents // given all core agents
const agents = { const agents = {
sisyphus: {}, sisyphus: {},
@ -47,20 +46,20 @@ describe("remapAgentKeysToDisplayNames", () => {
// when remapping // when remapping
const result = remapAgentKeysToDisplayNames(agents) const result = remapAgentKeysToDisplayNames(agents)
// then all get display name keys while original keys still work // then all get display name keys without lowercase duplicates
expect(result["Sisyphus (Ultraworker)"]).toBeDefined() expect(result["Sisyphus (Ultraworker)"]).toBeDefined()
expect(result["sisyphus"]).toBeDefined() expect(result["sisyphus"]).toBeUndefined()
expect(result["Hephaestus (Deep Agent)"]).toBeDefined() expect(result["Hephaestus (Deep Agent)"]).toBeDefined()
expect(result["hephaestus"]).toBeDefined() expect(result["hephaestus"]).toBeUndefined()
expect(result["Prometheus (Plan Builder)"]).toBeDefined() expect(result["Prometheus (Plan Builder)"]).toBeDefined()
expect(result["prometheus"]).toBeDefined() expect(result["prometheus"]).toBeUndefined()
expect(result["Atlas (Plan Executor)"]).toBeDefined() expect(result["Atlas (Plan Executor)"]).toBeDefined()
expect(result["atlas"]).toBeDefined() expect(result["atlas"]).toBeUndefined()
expect(result["Metis (Plan Consultant)"]).toBeDefined() expect(result["Metis (Plan Consultant)"]).toBeDefined()
expect(result["metis"]).toBeDefined() expect(result["metis"]).toBeUndefined()
expect(result["Momus (Plan Critic)"]).toBeDefined() expect(result["Momus (Plan Critic)"]).toBeDefined()
expect(result["momus"]).toBeDefined() expect(result["momus"]).toBeUndefined()
expect(result["Sisyphus-Junior"]).toBeDefined() expect(result["Sisyphus-Junior"]).toBeDefined()
expect(result["sisyphus-junior"]).toBeDefined() expect(result["sisyphus-junior"]).toBeUndefined()
}) })
}) })

1
src/plugin-handlers/agent-key-remapper.ts
View File

@ -9,7 +9,6 @@ export function remapAgentKeysToDisplayNames(
const displayName = AGENT_DISPLAY_NAMES[key] const displayName = AGENT_DISPLAY_NAMES[key]
if (displayName && displayName !== key) { if (displayName && displayName !== key) {
result[displayName] = value result[displayName] = value
result[key] = value
} else { } else {
result[key] = value result[key] = value
} }