f146aeff0f
* style(tests): normalize BDD comments from '// #given' to '// given' - Replace 4,668 Python-style BDD comments across 107 test files - Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then - Also handles no-space variants: //#given -> // given * fix(rules-injector): prefer output.metadata.filePath over output.title - Extract file path resolution to dedicated output-path.ts module - Prefer metadata.filePath which contains actual file path - Fall back to output.title only when metadata unavailable - Fixes issue where rules weren't injected when tool output title was a label * feat(slashcommand): add optional user_message parameter - Add user_message optional parameter for command arguments - Model can now call: command='publish' user_message='patch' - Improves error messages with clearer format guidance - Helps LLMs understand correct parameter usage * feat(hooks): restore compaction-context-injector hook - Restore hook deleted in cbbc7bd0 for session compaction context - Injects 7 mandatory sections: User Requests, Final Goal, Work Completed, Remaining Tasks, Active Working Context, MUST NOT Do, Agent Verification State - Re-register in hooks/index.ts and main plugin entry * refactor(background-agent): split manager.ts into focused modules - Extract constants.ts for TTL values and internal types (52 lines) - Extract state.ts for TaskStateManager class (204 lines) - Extract spawner.ts for task creation logic (244 lines) - Extract result-handler.ts for completion handling (265 lines) - Reduce manager.ts from 1377 to 755 lines (45% reduction) - Maintain backward compatible exports * refactor(agents): split prometheus-prompt.ts into subdirectory - Move 1196-line prometheus-prompt.ts to prometheus/ subdirectory - Organize prompt sections into separate files for maintainability - Update agents/index.ts exports * refactor(delegate-task): split tools.ts into focused modules - Extract categories.ts for category definitions and routing - Extract executor.ts for task execution logic - Extract helpers.ts for utility functions - Extract prompt-builder.ts for prompt construction - Reduce tools.ts complexity with cleaner separation of concerns * refactor(builtin-skills): split skills.ts into individual skill files - Move each skill to dedicated file in skills/ subdirectory - Create barrel export for backward compatibility - Improve maintainability with focused skill modules * chore: update import paths and lockfile - Update prometheus import path after refactor - Update bun.lock * fix(tests): complete BDD comment normalization - Fix remaining #when/#then patterns missed by initial sed - Affected: state.test.ts, events.test.ts --------- Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com>
289 lines
9.5 KiB
TypeScript
289 lines
9.5 KiB
TypeScript
import { describe, expect, test, beforeEach, afterEach } from "bun:test"
|
|
import { detectExternalNotificationPlugin, getNotificationConflictWarning } from "./external-plugin-detector"
|
|
import * as fs from "node:fs"
|
|
import * as path from "node:path"
|
|
import * as os from "node:os"
|
|
|
|
describe("external-plugin-detector", () => {
|
|
let tempDir: string
|
|
|
|
beforeEach(() => {
|
|
tempDir = fs.mkdtempSync(path.join(os.tmpdir(), "omo-test-"))
|
|
})
|
|
|
|
afterEach(() => {
|
|
fs.rmSync(tempDir, { recursive: true, force: true })
|
|
})
|
|
|
|
describe("detectExternalNotificationPlugin", () => {
|
|
test("should return detected=false when no plugins configured", () => {
|
|
// given - empty directory
|
|
// when
|
|
const result = detectExternalNotificationPlugin(tempDir)
|
|
// then
|
|
expect(result.detected).toBe(false)
|
|
expect(result.pluginName).toBeNull()
|
|
})
|
|
|
|
test("should return detected=false when only oh-my-opencode is configured", () => {
|
|
// given - opencode.json with only oh-my-opencode
|
|
const opencodeDir = path.join(tempDir, ".opencode")
|
|
fs.mkdirSync(opencodeDir, { recursive: true })
|
|
fs.writeFileSync(
|
|
path.join(opencodeDir, "opencode.json"),
|
|
JSON.stringify({ plugin: ["oh-my-opencode"] })
|
|
)
|
|
|
|
// when
|
|
const result = detectExternalNotificationPlugin(tempDir)
|
|
|
|
// then
|
|
expect(result.detected).toBe(false)
|
|
expect(result.pluginName).toBeNull()
|
|
expect(result.allPlugins).toContain("oh-my-opencode")
|
|
})
|
|
|
|
test("should detect opencode-notifier plugin", () => {
|
|
// given - opencode.json with opencode-notifier
|
|
const opencodeDir = path.join(tempDir, ".opencode")
|
|
fs.mkdirSync(opencodeDir, { recursive: true })
|
|
fs.writeFileSync(
|
|
path.join(opencodeDir, "opencode.json"),
|
|
JSON.stringify({ plugin: ["oh-my-opencode", "opencode-notifier"] })
|
|
)
|
|
|
|
// when
|
|
const result = detectExternalNotificationPlugin(tempDir)
|
|
|
|
// then
|
|
expect(result.detected).toBe(true)
|
|
expect(result.pluginName).toBe("opencode-notifier")
|
|
})
|
|
|
|
test("should detect opencode-notifier with version suffix", () => {
|
|
// given - opencode.json with versioned opencode-notifier
|
|
const opencodeDir = path.join(tempDir, ".opencode")
|
|
fs.mkdirSync(opencodeDir, { recursive: true })
|
|
fs.writeFileSync(
|
|
path.join(opencodeDir, "opencode.json"),
|
|
JSON.stringify({ plugin: ["oh-my-opencode", "opencode-notifier@1.2.3"] })
|
|
)
|
|
|
|
// when
|
|
const result = detectExternalNotificationPlugin(tempDir)
|
|
|
|
// then
|
|
expect(result.detected).toBe(true)
|
|
expect(result.pluginName).toBe("opencode-notifier")
|
|
})
|
|
|
|
test("should detect @mohak34/opencode-notifier", () => {
|
|
// given - opencode.json with scoped package name
|
|
const opencodeDir = path.join(tempDir, ".opencode")
|
|
fs.mkdirSync(opencodeDir, { recursive: true })
|
|
fs.writeFileSync(
|
|
path.join(opencodeDir, "opencode.json"),
|
|
JSON.stringify({ plugin: ["oh-my-opencode", "@mohak34/opencode-notifier"] })
|
|
)
|
|
|
|
// when
|
|
const result = detectExternalNotificationPlugin(tempDir)
|
|
|
|
// then - returns the matched known plugin pattern, not the full entry
|
|
expect(result.detected).toBe(true)
|
|
expect(result.pluginName).toContain("opencode-notifier")
|
|
})
|
|
|
|
test("should handle JSONC format with comments", () => {
|
|
// given - opencode.jsonc with comments
|
|
const opencodeDir = path.join(tempDir, ".opencode")
|
|
fs.mkdirSync(opencodeDir, { recursive: true })
|
|
fs.writeFileSync(
|
|
path.join(opencodeDir, "opencode.jsonc"),
|
|
`{
|
|
// This is a comment
|
|
"plugin": [
|
|
"oh-my-opencode",
|
|
"opencode-notifier" // Another comment
|
|
]
|
|
}`
|
|
)
|
|
|
|
// when
|
|
const result = detectExternalNotificationPlugin(tempDir)
|
|
|
|
// then
|
|
expect(result.detected).toBe(true)
|
|
expect(result.pluginName).toBe("opencode-notifier")
|
|
})
|
|
})
|
|
|
|
describe("false positive prevention", () => {
|
|
test("should NOT match my-opencode-notifier-fork (suffix variation)", () => {
|
|
// given - plugin with similar name but different suffix
|
|
const opencodeDir = path.join(tempDir, ".opencode")
|
|
fs.mkdirSync(opencodeDir, { recursive: true })
|
|
fs.writeFileSync(
|
|
path.join(opencodeDir, "opencode.json"),
|
|
JSON.stringify({ plugin: ["my-opencode-notifier-fork"] })
|
|
)
|
|
|
|
// when
|
|
const result = detectExternalNotificationPlugin(tempDir)
|
|
|
|
// then
|
|
expect(result.detected).toBe(false)
|
|
expect(result.pluginName).toBeNull()
|
|
})
|
|
|
|
test("should NOT match some-other-plugin/opencode-notifier-like (path with similar name)", () => {
|
|
// given - plugin path containing similar substring
|
|
const opencodeDir = path.join(tempDir, ".opencode")
|
|
fs.mkdirSync(opencodeDir, { recursive: true })
|
|
fs.writeFileSync(
|
|
path.join(opencodeDir, "opencode.json"),
|
|
JSON.stringify({ plugin: ["some-other-plugin/opencode-notifier-like"] })
|
|
)
|
|
|
|
// when
|
|
const result = detectExternalNotificationPlugin(tempDir)
|
|
|
|
// then
|
|
expect(result.detected).toBe(false)
|
|
expect(result.pluginName).toBeNull()
|
|
})
|
|
|
|
test("should NOT match opencode-notifier-extended (prefix match but different package)", () => {
|
|
// given - plugin with prefix match but extended name
|
|
const opencodeDir = path.join(tempDir, ".opencode")
|
|
fs.mkdirSync(opencodeDir, { recursive: true })
|
|
fs.writeFileSync(
|
|
path.join(opencodeDir, "opencode.json"),
|
|
JSON.stringify({ plugin: ["opencode-notifier-extended"] })
|
|
)
|
|
|
|
// when
|
|
const result = detectExternalNotificationPlugin(tempDir)
|
|
|
|
// then
|
|
expect(result.detected).toBe(false)
|
|
expect(result.pluginName).toBeNull()
|
|
})
|
|
|
|
test("should match opencode-notifier exactly", () => {
|
|
// given - exact match
|
|
const opencodeDir = path.join(tempDir, ".opencode")
|
|
fs.mkdirSync(opencodeDir, { recursive: true })
|
|
fs.writeFileSync(
|
|
path.join(opencodeDir, "opencode.json"),
|
|
JSON.stringify({ plugin: ["opencode-notifier"] })
|
|
)
|
|
|
|
// when
|
|
const result = detectExternalNotificationPlugin(tempDir)
|
|
|
|
// then
|
|
expect(result.detected).toBe(true)
|
|
expect(result.pluginName).toBe("opencode-notifier")
|
|
})
|
|
|
|
test("should match opencode-notifier@1.2.3 (version suffix)", () => {
|
|
// given - version suffix
|
|
const opencodeDir = path.join(tempDir, ".opencode")
|
|
fs.mkdirSync(opencodeDir, { recursive: true })
|
|
fs.writeFileSync(
|
|
path.join(opencodeDir, "opencode.json"),
|
|
JSON.stringify({ plugin: ["opencode-notifier@1.2.3"] })
|
|
)
|
|
|
|
// when
|
|
const result = detectExternalNotificationPlugin(tempDir)
|
|
|
|
// then
|
|
expect(result.detected).toBe(true)
|
|
expect(result.pluginName).toBe("opencode-notifier")
|
|
})
|
|
|
|
test("should match @mohak34/opencode-notifier (scoped package)", () => {
|
|
// given - scoped package
|
|
const opencodeDir = path.join(tempDir, ".opencode")
|
|
fs.mkdirSync(opencodeDir, { recursive: true })
|
|
fs.writeFileSync(
|
|
path.join(opencodeDir, "opencode.json"),
|
|
JSON.stringify({ plugin: ["@mohak34/opencode-notifier"] })
|
|
)
|
|
|
|
// when
|
|
const result = detectExternalNotificationPlugin(tempDir)
|
|
|
|
// then
|
|
expect(result.detected).toBe(true)
|
|
expect(result.pluginName).toContain("opencode-notifier")
|
|
})
|
|
|
|
test("should match npm:opencode-notifier (npm prefix)", () => {
|
|
// given - npm prefix
|
|
const opencodeDir = path.join(tempDir, ".opencode")
|
|
fs.mkdirSync(opencodeDir, { recursive: true })
|
|
fs.writeFileSync(
|
|
path.join(opencodeDir, "opencode.json"),
|
|
JSON.stringify({ plugin: ["npm:opencode-notifier"] })
|
|
)
|
|
|
|
// when
|
|
const result = detectExternalNotificationPlugin(tempDir)
|
|
|
|
// then
|
|
expect(result.detected).toBe(true)
|
|
expect(result.pluginName).toBe("opencode-notifier")
|
|
})
|
|
|
|
test("should match npm:opencode-notifier@2.0.0 (npm prefix with version)", () => {
|
|
// given - npm prefix with version
|
|
const opencodeDir = path.join(tempDir, ".opencode")
|
|
fs.mkdirSync(opencodeDir, { recursive: true })
|
|
fs.writeFileSync(
|
|
path.join(opencodeDir, "opencode.json"),
|
|
JSON.stringify({ plugin: ["npm:opencode-notifier@2.0.0"] })
|
|
)
|
|
|
|
// when
|
|
const result = detectExternalNotificationPlugin(tempDir)
|
|
|
|
// then
|
|
expect(result.detected).toBe(true)
|
|
expect(result.pluginName).toBe("opencode-notifier")
|
|
})
|
|
|
|
test("should match file:///path/to/opencode-notifier (file path)", () => {
|
|
// given - file path
|
|
const opencodeDir = path.join(tempDir, ".opencode")
|
|
fs.mkdirSync(opencodeDir, { recursive: true })
|
|
fs.writeFileSync(
|
|
path.join(opencodeDir, "opencode.json"),
|
|
JSON.stringify({ plugin: ["file:///home/user/plugins/opencode-notifier"] })
|
|
)
|
|
|
|
// when
|
|
const result = detectExternalNotificationPlugin(tempDir)
|
|
|
|
// then
|
|
expect(result.detected).toBe(true)
|
|
expect(result.pluginName).toBe("opencode-notifier")
|
|
})
|
|
})
|
|
|
|
describe("getNotificationConflictWarning", () => {
|
|
test("should generate warning message with plugin name", () => {
|
|
// when
|
|
const warning = getNotificationConflictWarning("opencode-notifier")
|
|
|
|
// then
|
|
expect(warning).toContain("opencode-notifier")
|
|
expect(warning).toContain("session.idle")
|
|
expect(warning).toContain("auto-disabled")
|
|
expect(warning).toContain("force_enable")
|
|
})
|
|
})
|
|
})
|