c698a5b888
BREAKING CHANGE: Model resolution overhauled - Created centralized model-resolver.ts with priority chain: userModel → inheritedModel → systemDefaultModel - Removed model field from all 7 DEFAULT_CATEGORIES entries - Removed DEFAULT_MODEL constants from 10 agents - Removed singleton agent exports (use factories instead) - Made CategoryConfigSchema.model optional - CLI no longer generates model overrides - Empty strings treated as unset (uses fallback) Users must now: 1. Use factory functions (createOracleAgent, etc.) instead of singletons 2. Provide model explicitly or use systemDefaultModel 3. Configure category models explicitly if needed Fixes model fallback bug where hardcoded defaults overrode user's OpenCode configured model.
105 lines
3.0 KiB
TypeScript
105 lines
3.0 KiB
TypeScript
import { describe, test, expect } from "bun:test"
|
|
import { resolveCategoryConfig } from "./config-handler"
|
|
import type { CategoryConfig } from "../config/schema"
|
|
|
|
describe("Prometheus category config resolution", () => {
|
|
test("resolves ultrabrain category config", () => {
|
|
// #given
|
|
const categoryName = "ultrabrain"
|
|
|
|
// #when
|
|
const config = resolveCategoryConfig(categoryName)
|
|
|
|
// #then - DEFAULT_CATEGORIES only has temperature, not model
|
|
expect(config).toBeDefined()
|
|
expect(config?.model).toBeUndefined()
|
|
expect(config?.temperature).toBe(0.1)
|
|
})
|
|
|
|
test("resolves visual-engineering category config", () => {
|
|
// #given
|
|
const categoryName = "visual-engineering"
|
|
|
|
// #when
|
|
const config = resolveCategoryConfig(categoryName)
|
|
|
|
// #then - DEFAULT_CATEGORIES only has temperature, not model
|
|
expect(config).toBeDefined()
|
|
expect(config?.model).toBeUndefined()
|
|
expect(config?.temperature).toBe(0.7)
|
|
})
|
|
|
|
test("user categories override default categories", () => {
|
|
// #given
|
|
const categoryName = "ultrabrain"
|
|
const userCategories: Record<string, CategoryConfig> = {
|
|
ultrabrain: {
|
|
model: "google/antigravity-claude-opus-4-5-thinking",
|
|
temperature: 0.1,
|
|
},
|
|
}
|
|
|
|
// #when
|
|
const config = resolveCategoryConfig(categoryName, userCategories)
|
|
|
|
// #then
|
|
expect(config).toBeDefined()
|
|
expect(config?.model).toBe("google/antigravity-claude-opus-4-5-thinking")
|
|
expect(config?.temperature).toBe(0.1)
|
|
})
|
|
|
|
test("returns undefined for unknown category", () => {
|
|
// #given
|
|
const categoryName = "nonexistent-category"
|
|
|
|
// #when
|
|
const config = resolveCategoryConfig(categoryName)
|
|
|
|
// #then
|
|
expect(config).toBeUndefined()
|
|
})
|
|
|
|
test("falls back to default when user category has no entry", () => {
|
|
// #given
|
|
const categoryName = "ultrabrain"
|
|
const userCategories: Record<string, CategoryConfig> = {
|
|
"visual-engineering": {
|
|
model: "custom/visual-model",
|
|
},
|
|
}
|
|
|
|
// #when
|
|
const config = resolveCategoryConfig(categoryName, userCategories)
|
|
|
|
// #then - falls back to DEFAULT_CATEGORIES which has no model
|
|
expect(config).toBeDefined()
|
|
expect(config?.model).toBeUndefined()
|
|
expect(config?.temperature).toBe(0.1)
|
|
})
|
|
|
|
test("preserves all category properties (temperature, top_p, tools, etc.)", () => {
|
|
// #given
|
|
const categoryName = "custom-category"
|
|
const userCategories: Record<string, CategoryConfig> = {
|
|
"custom-category": {
|
|
model: "test/model",
|
|
temperature: 0.5,
|
|
top_p: 0.9,
|
|
maxTokens: 32000,
|
|
tools: { tool1: true, tool2: false },
|
|
},
|
|
}
|
|
|
|
// #when
|
|
const config = resolveCategoryConfig(categoryName, userCategories)
|
|
|
|
// #then
|
|
expect(config).toBeDefined()
|
|
expect(config?.model).toBe("test/model")
|
|
expect(config?.temperature).toBe(0.5)
|
|
expect(config?.top_p).toBe(0.9)
|
|
expect(config?.maxTokens).toBe(32000)
|
|
expect(config?.tools).toEqual({ tool1: true, tool2: false })
|
|
})
|
|
})
|