* style(tests): normalize BDD comments from '// #given' to '// given' - Replace 4,668 Python-style BDD comments across 107 test files - Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then - Also handles no-space variants: //#given -> // given * fix(rules-injector): prefer output.metadata.filePath over output.title - Extract file path resolution to dedicated output-path.ts module - Prefer metadata.filePath which contains actual file path - Fall back to output.title only when metadata unavailable - Fixes issue where rules weren't injected when tool output title was a label * feat(slashcommand): add optional user_message parameter - Add user_message optional parameter for command arguments - Model can now call: command='publish' user_message='patch' - Improves error messages with clearer format guidance - Helps LLMs understand correct parameter usage * feat(hooks): restore compaction-context-injector hook - Restore hook deleted in cbbc7bd0 for session compaction context - Injects 7 mandatory sections: User Requests, Final Goal, Work Completed, Remaining Tasks, Active Working Context, MUST NOT Do, Agent Verification State - Re-register in hooks/index.ts and main plugin entry * refactor(background-agent): split manager.ts into focused modules - Extract constants.ts for TTL values and internal types (52 lines) - Extract state.ts for TaskStateManager class (204 lines) - Extract spawner.ts for task creation logic (244 lines) - Extract result-handler.ts for completion handling (265 lines) - Reduce manager.ts from 1377 to 755 lines (45% reduction) - Maintain backward compatible exports * refactor(agents): split prometheus-prompt.ts into subdirectory - Move 1196-line prometheus-prompt.ts to prometheus/ subdirectory - Organize prompt sections into separate files for maintainability - Update agents/index.ts exports * refactor(delegate-task): split tools.ts into focused modules - Extract categories.ts for category definitions and routing - Extract executor.ts for task execution logic - Extract helpers.ts for utility functions - Extract prompt-builder.ts for prompt construction - Reduce tools.ts complexity with cleaner separation of concerns * refactor(builtin-skills): split skills.ts into individual skill files - Move each skill to dedicated file in skills/ subdirectory - Create barrel export for backward compatibility - Improve maintainability with focused skill modules * chore: update import paths and lockfile - Update prometheus import path after refactor - Update bun.lock * fix(tests): complete BDD comment normalization - Fix remaining #when/#then patterns missed by initial sed - Affected: state.test.ts, events.test.ts --------- Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com>
135 lines
4.4 KiB
TypeScript
135 lines
4.4 KiB
TypeScript
import { describe, it, expect, spyOn, afterEach } from "bun:test"
|
|
import * as lsp from "./lsp"
|
|
import type { LspServerInfo } from "../types"
|
|
|
|
describe("lsp check", () => {
|
|
describe("getLspServersInfo", () => {
|
|
it("returns array of server info", async () => {
|
|
// given
|
|
// when getting servers info
|
|
const servers = await lsp.getLspServersInfo()
|
|
|
|
// then should return array with expected structure
|
|
expect(Array.isArray(servers)).toBe(true)
|
|
servers.forEach((s) => {
|
|
expect(s.id).toBeDefined()
|
|
expect(typeof s.installed).toBe("boolean")
|
|
expect(Array.isArray(s.extensions)).toBe(true)
|
|
})
|
|
})
|
|
|
|
it("does not spawn 'which' command (windows compatibility)", async () => {
|
|
// given
|
|
const spawnSpy = spyOn(Bun, "spawn")
|
|
|
|
try {
|
|
// when getting servers info
|
|
await lsp.getLspServersInfo()
|
|
|
|
// then should not spawn which
|
|
const calls = spawnSpy.mock.calls
|
|
const whichCalls = calls.filter((c) => Array.isArray(c) && Array.isArray(c[0]) && c[0][0] === "which")
|
|
expect(whichCalls.length).toBe(0)
|
|
} finally {
|
|
spawnSpy.mockRestore()
|
|
}
|
|
})
|
|
})
|
|
|
|
describe("getLspServerStats", () => {
|
|
it("counts installed servers correctly", () => {
|
|
// given servers with mixed installation status
|
|
const servers = [
|
|
{ id: "ts", installed: true, extensions: [".ts"], source: "builtin" as const },
|
|
{ id: "py", installed: false, extensions: [".py"], source: "builtin" as const },
|
|
{ id: "go", installed: true, extensions: [".go"], source: "builtin" as const },
|
|
]
|
|
|
|
// when getting stats
|
|
const stats = lsp.getLspServerStats(servers)
|
|
|
|
// then should count correctly
|
|
expect(stats.installed).toBe(2)
|
|
expect(stats.total).toBe(3)
|
|
})
|
|
|
|
it("handles empty array", () => {
|
|
// given no servers
|
|
const servers: LspServerInfo[] = []
|
|
|
|
// when getting stats
|
|
const stats = lsp.getLspServerStats(servers)
|
|
|
|
// then should return zeros
|
|
expect(stats.installed).toBe(0)
|
|
expect(stats.total).toBe(0)
|
|
})
|
|
})
|
|
|
|
describe("checkLspServers", () => {
|
|
let getServersSpy: ReturnType<typeof spyOn>
|
|
|
|
afterEach(() => {
|
|
getServersSpy?.mockRestore()
|
|
})
|
|
|
|
it("returns warn when no servers installed", async () => {
|
|
// given no servers installed
|
|
getServersSpy = spyOn(lsp, "getLspServersInfo").mockResolvedValue([
|
|
{ id: "typescript-language-server", installed: false, extensions: [".ts"], source: "builtin" },
|
|
{ id: "pyright", installed: false, extensions: [".py"], source: "builtin" },
|
|
])
|
|
|
|
// when checking
|
|
const result = await lsp.checkLspServers()
|
|
|
|
// then should warn
|
|
expect(result.status).toBe("warn")
|
|
expect(result.message).toContain("No LSP servers")
|
|
})
|
|
|
|
it("returns pass when servers installed", async () => {
|
|
// given some servers installed
|
|
getServersSpy = spyOn(lsp, "getLspServersInfo").mockResolvedValue([
|
|
{ id: "typescript-language-server", installed: true, extensions: [".ts"], source: "builtin" },
|
|
{ id: "pyright", installed: false, extensions: [".py"], source: "builtin" },
|
|
])
|
|
|
|
// when checking
|
|
const result = await lsp.checkLspServers()
|
|
|
|
// then should pass with count
|
|
expect(result.status).toBe("pass")
|
|
expect(result.message).toContain("1/2")
|
|
})
|
|
|
|
it("lists installed and missing servers in details", async () => {
|
|
// given mixed installation
|
|
getServersSpy = spyOn(lsp, "getLspServersInfo").mockResolvedValue([
|
|
{ id: "typescript-language-server", installed: true, extensions: [".ts"], source: "builtin" },
|
|
{ id: "pyright", installed: false, extensions: [".py"], source: "builtin" },
|
|
])
|
|
|
|
// when checking
|
|
const result = await lsp.checkLspServers()
|
|
|
|
// then should list both
|
|
expect(result.details?.some((d) => d.includes("Installed"))).toBe(true)
|
|
expect(result.details?.some((d) => d.includes("Not found"))).toBe(true)
|
|
})
|
|
})
|
|
|
|
describe("getLspCheckDefinition", () => {
|
|
it("returns valid check definition", () => {
|
|
// given
|
|
// when getting definition
|
|
const def = lsp.getLspCheckDefinition()
|
|
|
|
// then should have required properties
|
|
expect(def.id).toBe("lsp-servers")
|
|
expect(def.category).toBe("tools")
|
|
expect(def.critical).toBe(false)
|
|
})
|
|
})
|
|
})
|