f146aeff0f
* style(tests): normalize BDD comments from '// #given' to '// given' - Replace 4,668 Python-style BDD comments across 107 test files - Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then - Also handles no-space variants: //#given -> // given * fix(rules-injector): prefer output.metadata.filePath over output.title - Extract file path resolution to dedicated output-path.ts module - Prefer metadata.filePath which contains actual file path - Fall back to output.title only when metadata unavailable - Fixes issue where rules weren't injected when tool output title was a label * feat(slashcommand): add optional user_message parameter - Add user_message optional parameter for command arguments - Model can now call: command='publish' user_message='patch' - Improves error messages with clearer format guidance - Helps LLMs understand correct parameter usage * feat(hooks): restore compaction-context-injector hook - Restore hook deleted in cbbc7bd0 for session compaction context - Injects 7 mandatory sections: User Requests, Final Goal, Work Completed, Remaining Tasks, Active Working Context, MUST NOT Do, Agent Verification State - Re-register in hooks/index.ts and main plugin entry * refactor(background-agent): split manager.ts into focused modules - Extract constants.ts for TTL values and internal types (52 lines) - Extract state.ts for TaskStateManager class (204 lines) - Extract spawner.ts for task creation logic (244 lines) - Extract result-handler.ts for completion handling (265 lines) - Reduce manager.ts from 1377 to 755 lines (45% reduction) - Maintain backward compatible exports * refactor(agents): split prometheus-prompt.ts into subdirectory - Move 1196-line prometheus-prompt.ts to prometheus/ subdirectory - Organize prompt sections into separate files for maintainability - Update agents/index.ts exports * refactor(delegate-task): split tools.ts into focused modules - Extract categories.ts for category definitions and routing - Extract executor.ts for task execution logic - Extract helpers.ts for utility functions - Extract prompt-builder.ts for prompt construction - Reduce tools.ts complexity with cleaner separation of concerns * refactor(builtin-skills): split skills.ts into individual skill files - Move each skill to dedicated file in skills/ subdirectory - Create barrel export for backward compatibility - Improve maintainability with focused skill modules * chore: update import paths and lockfile - Update prometheus import path after refactor - Update bun.lock * fix(tests): complete BDD comment normalization - Fix remaining #when/#then patterns missed by initial sed - Affected: state.test.ts, events.test.ts --------- Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com>
122 lines
2.9 KiB
TypeScript
122 lines
2.9 KiB
TypeScript
import { describe, expect, it } from "bun:test"
|
|
import { addResourceToParams, getResourceIndicator } from "./resource-indicator"
|
|
|
|
describe("getResourceIndicator", () => {
|
|
it("returns URL unchanged when already normalized", () => {
|
|
// given
|
|
const url = "https://mcp.example.com"
|
|
|
|
// when
|
|
const result = getResourceIndicator(url)
|
|
|
|
// then
|
|
expect(result).toBe("https://mcp.example.com")
|
|
})
|
|
|
|
it("strips trailing slash", () => {
|
|
// given
|
|
const url = "https://mcp.example.com/"
|
|
|
|
// when
|
|
const result = getResourceIndicator(url)
|
|
|
|
// then
|
|
expect(result).toBe("https://mcp.example.com")
|
|
})
|
|
|
|
it("strips query parameters", () => {
|
|
// given
|
|
const url = "https://mcp.example.com/v1?token=abc&debug=true"
|
|
|
|
// when
|
|
const result = getResourceIndicator(url)
|
|
|
|
// then
|
|
expect(result).toBe("https://mcp.example.com/v1")
|
|
})
|
|
|
|
it("strips fragment", () => {
|
|
// given
|
|
const url = "https://mcp.example.com/v1#section"
|
|
|
|
// when
|
|
const result = getResourceIndicator(url)
|
|
|
|
// then
|
|
expect(result).toBe("https://mcp.example.com/v1")
|
|
})
|
|
|
|
it("strips query and trailing slash together", () => {
|
|
// given
|
|
const url = "https://mcp.example.com/api/?key=val"
|
|
|
|
// when
|
|
const result = getResourceIndicator(url)
|
|
|
|
// then
|
|
expect(result).toBe("https://mcp.example.com/api")
|
|
})
|
|
|
|
it("preserves path segments", () => {
|
|
// given
|
|
const url = "https://mcp.example.com/org/project/v2"
|
|
|
|
// when
|
|
const result = getResourceIndicator(url)
|
|
|
|
// then
|
|
expect(result).toBe("https://mcp.example.com/org/project/v2")
|
|
})
|
|
|
|
it("preserves port number", () => {
|
|
// given
|
|
const url = "https://mcp.example.com:8443/api/"
|
|
|
|
// when
|
|
const result = getResourceIndicator(url)
|
|
|
|
// then
|
|
expect(result).toBe("https://mcp.example.com:8443/api")
|
|
})
|
|
})
|
|
|
|
describe("addResourceToParams", () => {
|
|
it("sets resource parameter on empty params", () => {
|
|
// given
|
|
const params = new URLSearchParams()
|
|
const resource = "https://mcp.example.com"
|
|
|
|
// when
|
|
addResourceToParams(params, resource)
|
|
|
|
// then
|
|
expect(params.get("resource")).toBe("https://mcp.example.com")
|
|
})
|
|
|
|
it("adds resource alongside existing parameters", () => {
|
|
// given
|
|
const params = new URLSearchParams({ grant_type: "authorization_code" })
|
|
const resource = "https://mcp.example.com/v1"
|
|
|
|
// when
|
|
addResourceToParams(params, resource)
|
|
|
|
// then
|
|
expect(params.get("grant_type")).toBe("authorization_code")
|
|
expect(params.get("resource")).toBe("https://mcp.example.com/v1")
|
|
})
|
|
|
|
it("overwrites existing resource parameter", () => {
|
|
// given
|
|
const params = new URLSearchParams({ resource: "https://old.example.com" })
|
|
const resource = "https://new.example.com"
|
|
|
|
// when
|
|
addResourceToParams(params, resource)
|
|
|
|
// then
|
|
expect(params.get("resource")).toBe("https://new.example.com")
|
|
expect(params.getAll("resource")).toHaveLength(1)
|
|
})
|
|
})
|