Replace platform-specific 'which'/'where' commands with cross-platform Bun.which() API to fix Windows compatibility issues and simplify code. Fixes: - #1027: Comment-checker binary crashes on Windows (missing 'check' subcommand) - #1036: Session-notification listens to non-existent events - #1033: Infinite loop in session notifications - #599: Doctor incorrectly reports OpenCode as not installed on Windows - #1005: PowerShell path detection corruption on Windows Changes: - Use Bun.which() instead of spawning 'which'/'where' commands - Add 'check' subcommand to comment-checker invocation - Remove non-existent event listeners (session.updated, message.created) - Prevent notification commands from resetting their own state - Fix edge case: clear notifiedSessions if activity occurs during notification All changes are cross-platform compatible and tested on Windows/Linux/macOS.
50 lines
1.4 KiB
TypeScript
50 lines
1.4 KiB
TypeScript
import { spawn } from "bun"
|
|
|
|
type Platform = "darwin" | "linux" | "win32" | "unsupported"
|
|
|
|
async function findCommand(commandName: string): Promise<string | null> {
|
|
try {
|
|
return Bun.which(commandName)
|
|
} catch {
|
|
return null
|
|
}
|
|
}
|
|
|
|
function createCommandFinder(commandName: string): () => Promise<string | null> {
|
|
let cachedPath: string | null = null
|
|
let pending: Promise<string | null> | null = null
|
|
|
|
return async () => {
|
|
if (cachedPath !== null) return cachedPath
|
|
if (pending) return pending
|
|
|
|
pending = (async () => {
|
|
const path = await findCommand(commandName)
|
|
cachedPath = path
|
|
return path
|
|
})()
|
|
|
|
return pending
|
|
}
|
|
}
|
|
|
|
export const getNotifySendPath = createCommandFinder("notify-send")
|
|
export const getOsascriptPath = createCommandFinder("osascript")
|
|
export const getPowershellPath = createCommandFinder("powershell")
|
|
export const getAfplayPath = createCommandFinder("afplay")
|
|
export const getPaplayPath = createCommandFinder("paplay")
|
|
export const getAplayPath = createCommandFinder("aplay")
|
|
|
|
export function startBackgroundCheck(platform: Platform): void {
|
|
if (platform === "darwin") {
|
|
getOsascriptPath().catch(() => {})
|
|
getAfplayPath().catch(() => {})
|
|
} else if (platform === "linux") {
|
|
getNotifySendPath().catch(() => {})
|
|
getPaplayPath().catch(() => {})
|
|
getAplayPath().catch(() => {})
|
|
} else if (platform === "win32") {
|
|
getPowershellPath().catch(() => {})
|
|
}
|
|
}
|