f146aeff0f
* style(tests): normalize BDD comments from '// #given' to '// given' - Replace 4,668 Python-style BDD comments across 107 test files - Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then - Also handles no-space variants: //#given -> // given * fix(rules-injector): prefer output.metadata.filePath over output.title - Extract file path resolution to dedicated output-path.ts module - Prefer metadata.filePath which contains actual file path - Fall back to output.title only when metadata unavailable - Fixes issue where rules weren't injected when tool output title was a label * feat(slashcommand): add optional user_message parameter - Add user_message optional parameter for command arguments - Model can now call: command='publish' user_message='patch' - Improves error messages with clearer format guidance - Helps LLMs understand correct parameter usage * feat(hooks): restore compaction-context-injector hook - Restore hook deleted in cbbc7bd0 for session compaction context - Injects 7 mandatory sections: User Requests, Final Goal, Work Completed, Remaining Tasks, Active Working Context, MUST NOT Do, Agent Verification State - Re-register in hooks/index.ts and main plugin entry * refactor(background-agent): split manager.ts into focused modules - Extract constants.ts for TTL values and internal types (52 lines) - Extract state.ts for TaskStateManager class (204 lines) - Extract spawner.ts for task creation logic (244 lines) - Extract result-handler.ts for completion handling (265 lines) - Reduce manager.ts from 1377 to 755 lines (45% reduction) - Maintain backward compatible exports * refactor(agents): split prometheus-prompt.ts into subdirectory - Move 1196-line prometheus-prompt.ts to prometheus/ subdirectory - Organize prompt sections into separate files for maintainability - Update agents/index.ts exports * refactor(delegate-task): split tools.ts into focused modules - Extract categories.ts for category definitions and routing - Extract executor.ts for task execution logic - Extract helpers.ts for utility functions - Extract prompt-builder.ts for prompt construction - Reduce tools.ts complexity with cleaner separation of concerns * refactor(builtin-skills): split skills.ts into individual skill files - Move each skill to dedicated file in skills/ subdirectory - Create barrel export for backward compatibility - Improve maintainability with focused skill modules * chore: update import paths and lockfile - Update prometheus import path after refactor - Update bun.lock * fix(tests): complete BDD comment normalization - Fix remaining #when/#then patterns missed by initial sed - Affected: state.test.ts, events.test.ts --------- Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com>
59 lines
2.0 KiB
TypeScript
59 lines
2.0 KiB
TypeScript
import { describe, test, expect } from "bun:test"
|
|
import { MOMUS_SYSTEM_PROMPT } from "./momus"
|
|
|
|
function escapeRegExp(value: string) {
|
|
return value.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")
|
|
}
|
|
|
|
describe("MOMUS_SYSTEM_PROMPT policy requirements", () => {
|
|
test("should treat SYSTEM DIRECTIVE as ignorable/stripped", () => {
|
|
// given
|
|
const prompt = MOMUS_SYSTEM_PROMPT
|
|
|
|
// when / #then
|
|
// Should mention that system directives are ignored
|
|
expect(prompt.toLowerCase()).toMatch(/system directive.*ignore|ignore.*system directive/)
|
|
// Should give examples of system directive patterns
|
|
expect(prompt).toMatch(/<system-reminder>|system-reminder/)
|
|
})
|
|
|
|
test("should extract paths containing .sisyphus/plans/ and ending in .md", () => {
|
|
// given
|
|
const prompt = MOMUS_SYSTEM_PROMPT
|
|
|
|
// when / #then
|
|
expect(prompt).toContain(".sisyphus/plans/")
|
|
expect(prompt).toContain(".md")
|
|
// New extraction policy should be mentioned
|
|
expect(prompt.toLowerCase()).toMatch(/extract|search|find path/)
|
|
})
|
|
|
|
test("should NOT teach that 'Please review' is INVALID (conversational wrapper allowed)", () => {
|
|
// given
|
|
const prompt = MOMUS_SYSTEM_PROMPT
|
|
|
|
// when / #then
|
|
// In RED phase, this will FAIL because current prompt explicitly lists this as INVALID
|
|
const invalidExample = "Please review .sisyphus/plans/plan.md"
|
|
const rejectionTeaching = new RegExp(
|
|
`reject.*${escapeRegExp(invalidExample)}`,
|
|
"i",
|
|
)
|
|
|
|
// We want the prompt to NOT reject this anymore.
|
|
// If it's still in the "INVALID" list, this test should fail.
|
|
expect(prompt).not.toMatch(rejectionTeaching)
|
|
})
|
|
|
|
test("should handle ambiguity (2+ paths) and 'no path found' rejection", () => {
|
|
// given
|
|
const prompt = MOMUS_SYSTEM_PROMPT
|
|
|
|
// when / #then
|
|
// Should mention what happens when multiple paths are found
|
|
expect(prompt.toLowerCase()).toMatch(/multiple|ambiguous|2\+|two/)
|
|
// Should mention rejection if no path found
|
|
expect(prompt.toLowerCase()).toMatch(/no.*path.*found|reject.*no.*path/)
|
|
})
|
|
})
|