* style(tests): normalize BDD comments from '// #given' to '// given' - Replace 4,668 Python-style BDD comments across 107 test files - Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then - Also handles no-space variants: //#given -> // given * fix(rules-injector): prefer output.metadata.filePath over output.title - Extract file path resolution to dedicated output-path.ts module - Prefer metadata.filePath which contains actual file path - Fall back to output.title only when metadata unavailable - Fixes issue where rules weren't injected when tool output title was a label * feat(slashcommand): add optional user_message parameter - Add user_message optional parameter for command arguments - Model can now call: command='publish' user_message='patch' - Improves error messages with clearer format guidance - Helps LLMs understand correct parameter usage * feat(hooks): restore compaction-context-injector hook - Restore hook deleted in cbbc7bd0 for session compaction context - Injects 7 mandatory sections: User Requests, Final Goal, Work Completed, Remaining Tasks, Active Working Context, MUST NOT Do, Agent Verification State - Re-register in hooks/index.ts and main plugin entry * refactor(background-agent): split manager.ts into focused modules - Extract constants.ts for TTL values and internal types (52 lines) - Extract state.ts for TaskStateManager class (204 lines) - Extract spawner.ts for task creation logic (244 lines) - Extract result-handler.ts for completion handling (265 lines) - Reduce manager.ts from 1377 to 755 lines (45% reduction) - Maintain backward compatible exports * refactor(agents): split prometheus-prompt.ts into subdirectory - Move 1196-line prometheus-prompt.ts to prometheus/ subdirectory - Organize prompt sections into separate files for maintainability - Update agents/index.ts exports * refactor(delegate-task): split tools.ts into focused modules - Extract categories.ts for category definitions and routing - Extract executor.ts for task execution logic - Extract helpers.ts for utility functions - Extract prompt-builder.ts for prompt construction - Reduce tools.ts complexity with cleaner separation of concerns * refactor(builtin-skills): split skills.ts into individual skill files - Move each skill to dedicated file in skills/ subdirectory - Create barrel export for backward compatibility - Improve maintainability with focused skill modules * chore: update import paths and lockfile - Update prometheus import path after refactor - Update bun.lock * fix(tests): complete BDD comment normalization - Fix remaining #when/#then patterns missed by initial sed - Affected: state.test.ts, events.test.ts --------- Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com>
158 lines
4.6 KiB
TypeScript
158 lines
4.6 KiB
TypeScript
import { describe, it, expect } from "bun:test"
|
|
import { AGENT_DISPLAY_NAMES, getAgentDisplayName } from "./agent-display-names"
|
|
|
|
describe("getAgentDisplayName", () => {
|
|
it("returns display name for lowercase config key (new format)", () => {
|
|
// given config key "sisyphus"
|
|
const configKey = "sisyphus"
|
|
|
|
// when getAgentDisplayName called
|
|
const result = getAgentDisplayName(configKey)
|
|
|
|
// then returns "Sisyphus (Ultraworker)"
|
|
expect(result).toBe("Sisyphus (Ultraworker)")
|
|
})
|
|
|
|
it("returns display name for uppercase config key (old format - case-insensitive)", () => {
|
|
// given config key "Sisyphus" (old format)
|
|
const configKey = "Sisyphus"
|
|
|
|
// when getAgentDisplayName called
|
|
const result = getAgentDisplayName(configKey)
|
|
|
|
// then returns "Sisyphus (Ultraworker)" (case-insensitive lookup)
|
|
expect(result).toBe("Sisyphus (Ultraworker)")
|
|
})
|
|
|
|
it("returns original key for unknown agents (fallback)", () => {
|
|
// given config key "custom-agent"
|
|
const configKey = "custom-agent"
|
|
|
|
// when getAgentDisplayName called
|
|
const result = getAgentDisplayName(configKey)
|
|
|
|
// then returns "custom-agent" (original key unchanged)
|
|
expect(result).toBe("custom-agent")
|
|
})
|
|
|
|
it("returns display name for atlas", () => {
|
|
// given config key "atlas"
|
|
const configKey = "atlas"
|
|
|
|
// when getAgentDisplayName called
|
|
const result = getAgentDisplayName(configKey)
|
|
|
|
// then returns "Atlas (Plan Execution Orchestrator)"
|
|
expect(result).toBe("Atlas (Plan Execution Orchestrator)")
|
|
})
|
|
|
|
it("returns display name for prometheus", () => {
|
|
// given config key "prometheus"
|
|
const configKey = "prometheus"
|
|
|
|
// when getAgentDisplayName called
|
|
const result = getAgentDisplayName(configKey)
|
|
|
|
// then returns "Prometheus (Plan Builder)"
|
|
expect(result).toBe("Prometheus (Plan Builder)")
|
|
})
|
|
|
|
it("returns display name for sisyphus-junior", () => {
|
|
// given config key "sisyphus-junior"
|
|
const configKey = "sisyphus-junior"
|
|
|
|
// when getAgentDisplayName called
|
|
const result = getAgentDisplayName(configKey)
|
|
|
|
// then returns "Sisyphus-Junior"
|
|
expect(result).toBe("Sisyphus-Junior")
|
|
})
|
|
|
|
it("returns display name for metis", () => {
|
|
// given config key "metis"
|
|
const configKey = "metis"
|
|
|
|
// when getAgentDisplayName called
|
|
const result = getAgentDisplayName(configKey)
|
|
|
|
// then returns "Metis (Plan Consultant)"
|
|
expect(result).toBe("Metis (Plan Consultant)")
|
|
})
|
|
|
|
it("returns display name for momus", () => {
|
|
// given config key "momus"
|
|
const configKey = "momus"
|
|
|
|
// when getAgentDisplayName called
|
|
const result = getAgentDisplayName(configKey)
|
|
|
|
// then returns "Momus (Plan Reviewer)"
|
|
expect(result).toBe("Momus (Plan Reviewer)")
|
|
})
|
|
|
|
it("returns display name for oracle", () => {
|
|
// given config key "oracle"
|
|
const configKey = "oracle"
|
|
|
|
// when getAgentDisplayName called
|
|
const result = getAgentDisplayName(configKey)
|
|
|
|
// then returns "oracle"
|
|
expect(result).toBe("oracle")
|
|
})
|
|
|
|
it("returns display name for librarian", () => {
|
|
// given config key "librarian"
|
|
const configKey = "librarian"
|
|
|
|
// when getAgentDisplayName called
|
|
const result = getAgentDisplayName(configKey)
|
|
|
|
// then returns "librarian"
|
|
expect(result).toBe("librarian")
|
|
})
|
|
|
|
it("returns display name for explore", () => {
|
|
// given config key "explore"
|
|
const configKey = "explore"
|
|
|
|
// when getAgentDisplayName called
|
|
const result = getAgentDisplayName(configKey)
|
|
|
|
// then returns "explore"
|
|
expect(result).toBe("explore")
|
|
})
|
|
|
|
it("returns display name for multimodal-looker", () => {
|
|
// given config key "multimodal-looker"
|
|
const configKey = "multimodal-looker"
|
|
|
|
// when getAgentDisplayName called
|
|
const result = getAgentDisplayName(configKey)
|
|
|
|
// then returns "multimodal-looker"
|
|
expect(result).toBe("multimodal-looker")
|
|
})
|
|
})
|
|
|
|
describe("AGENT_DISPLAY_NAMES", () => {
|
|
it("contains all expected agent mappings", () => {
|
|
// given expected mappings
|
|
const expectedMappings = {
|
|
sisyphus: "Sisyphus (Ultraworker)",
|
|
atlas: "Atlas (Plan Execution Orchestrator)",
|
|
prometheus: "Prometheus (Plan Builder)",
|
|
"sisyphus-junior": "Sisyphus-Junior",
|
|
metis: "Metis (Plan Consultant)",
|
|
momus: "Momus (Plan Reviewer)",
|
|
oracle: "oracle",
|
|
librarian: "librarian",
|
|
explore: "explore",
|
|
"multimodal-looker": "multimodal-looker",
|
|
}
|
|
|
|
// when checking the constant
|
|
// then contains all expected mappings
|
|
expect(AGENT_DISPLAY_NAMES).toEqual(expectedMappings)
|
|
})
|
|
}) |