* style(tests): normalize BDD comments from '// #given' to '// given' - Replace 4,668 Python-style BDD comments across 107 test files - Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then - Also handles no-space variants: //#given -> // given * fix(rules-injector): prefer output.metadata.filePath over output.title - Extract file path resolution to dedicated output-path.ts module - Prefer metadata.filePath which contains actual file path - Fall back to output.title only when metadata unavailable - Fixes issue where rules weren't injected when tool output title was a label * feat(slashcommand): add optional user_message parameter - Add user_message optional parameter for command arguments - Model can now call: command='publish' user_message='patch' - Improves error messages with clearer format guidance - Helps LLMs understand correct parameter usage * feat(hooks): restore compaction-context-injector hook - Restore hook deleted in cbbc7bd0 for session compaction context - Injects 7 mandatory sections: User Requests, Final Goal, Work Completed, Remaining Tasks, Active Working Context, MUST NOT Do, Agent Verification State - Re-register in hooks/index.ts and main plugin entry * refactor(background-agent): split manager.ts into focused modules - Extract constants.ts for TTL values and internal types (52 lines) - Extract state.ts for TaskStateManager class (204 lines) - Extract spawner.ts for task creation logic (244 lines) - Extract result-handler.ts for completion handling (265 lines) - Reduce manager.ts from 1377 to 755 lines (45% reduction) - Maintain backward compatible exports * refactor(agents): split prometheus-prompt.ts into subdirectory - Move 1196-line prometheus-prompt.ts to prometheus/ subdirectory - Organize prompt sections into separate files for maintainability - Update agents/index.ts exports * refactor(delegate-task): split tools.ts into focused modules - Extract categories.ts for category definitions and routing - Extract executor.ts for task execution logic - Extract helpers.ts for utility functions - Extract prompt-builder.ts for prompt construction - Reduce tools.ts complexity with cleaner separation of concerns * refactor(builtin-skills): split skills.ts into individual skill files - Move each skill to dedicated file in skills/ subdirectory - Create barrel export for backward compatibility - Improve maintainability with focused skill modules * chore: update import paths and lockfile - Update prometheus import path after refactor - Update bun.lock * fix(tests): complete BDD comment normalization - Fix remaining #when/#then patterns missed by initial sed - Affected: state.test.ts, events.test.ts --------- Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com>
137 lines
4.0 KiB
TypeScript
137 lines
4.0 KiB
TypeScript
import { describe, it, expect } from "bun:test";
|
|
import { createQuestionLabelTruncatorHook } from "./index";
|
|
|
|
describe("createQuestionLabelTruncatorHook", () => {
|
|
const hook = createQuestionLabelTruncatorHook();
|
|
|
|
describe("tool.execute.before", () => {
|
|
it("truncates labels exceeding 30 characters with ellipsis", async () => {
|
|
// given
|
|
const longLabel = "This is a very long label that exceeds thirty characters";
|
|
const input = { tool: "AskUserQuestion" };
|
|
const output = {
|
|
args: {
|
|
questions: [
|
|
{
|
|
question: "Choose an option",
|
|
options: [
|
|
{ label: longLabel, description: "A long option" },
|
|
],
|
|
},
|
|
],
|
|
},
|
|
};
|
|
|
|
// when
|
|
await hook["tool.execute.before"]?.(input as any, output as any);
|
|
|
|
// then
|
|
const truncatedLabel = (output.args as any).questions[0].options[0].label;
|
|
expect(truncatedLabel.length).toBeLessThanOrEqual(30);
|
|
expect(truncatedLabel).toBe("This is a very long label t...");
|
|
expect(truncatedLabel.endsWith("...")).toBe(true);
|
|
});
|
|
|
|
it("preserves labels within 30 characters", async () => {
|
|
// given
|
|
const shortLabel = "Short label";
|
|
const input = { tool: "AskUserQuestion" };
|
|
const output = {
|
|
args: {
|
|
questions: [
|
|
{
|
|
question: "Choose an option",
|
|
options: [
|
|
{ label: shortLabel, description: "A short option" },
|
|
],
|
|
},
|
|
],
|
|
},
|
|
};
|
|
|
|
// when
|
|
await hook["tool.execute.before"]?.(input as any, output as any);
|
|
|
|
// then
|
|
const resultLabel = (output.args as any).questions[0].options[0].label;
|
|
expect(resultLabel).toBe(shortLabel);
|
|
});
|
|
|
|
it("handles exactly 30 character labels without truncation", async () => {
|
|
// given
|
|
const exactLabel = "Exactly thirty chars here!!!!!"; // 30 chars
|
|
expect(exactLabel.length).toBe(30);
|
|
const input = { tool: "ask_user_question" };
|
|
const output = {
|
|
args: {
|
|
questions: [
|
|
{
|
|
question: "Choose",
|
|
options: [{ label: exactLabel }],
|
|
},
|
|
],
|
|
},
|
|
};
|
|
|
|
// when
|
|
await hook["tool.execute.before"]?.(input as any, output as any);
|
|
|
|
// then
|
|
const resultLabel = (output.args as any).questions[0].options[0].label;
|
|
expect(resultLabel).toBe(exactLabel);
|
|
});
|
|
|
|
it("ignores non-AskUserQuestion tools", async () => {
|
|
// given
|
|
const input = { tool: "Bash" };
|
|
const output = {
|
|
args: { command: "echo hello" },
|
|
};
|
|
const originalArgs = { ...output.args };
|
|
|
|
// when
|
|
await hook["tool.execute.before"]?.(input as any, output as any);
|
|
|
|
// then
|
|
expect(output.args).toEqual(originalArgs);
|
|
});
|
|
|
|
it("handles multiple questions with multiple options", async () => {
|
|
// given
|
|
const input = { tool: "AskUserQuestion" };
|
|
const output = {
|
|
args: {
|
|
questions: [
|
|
{
|
|
question: "Q1",
|
|
options: [
|
|
{ label: "Very long label number one that needs truncation" },
|
|
{ label: "Short" },
|
|
],
|
|
},
|
|
{
|
|
question: "Q2",
|
|
options: [
|
|
{ label: "Another extremely long label for testing purposes" },
|
|
],
|
|
},
|
|
],
|
|
},
|
|
};
|
|
|
|
// when
|
|
await hook["tool.execute.before"]?.(input as any, output as any);
|
|
|
|
// then
|
|
const q1opts = (output.args as any).questions[0].options;
|
|
const q2opts = (output.args as any).questions[1].options;
|
|
|
|
expect(q1opts[0].label).toBe("Very long label number one ...");
|
|
expect(q1opts[0].label.length).toBeLessThanOrEqual(30);
|
|
expect(q1opts[1].label).toBe("Short");
|
|
expect(q2opts[0].label).toBe("Another extremely long labe...");
|
|
expect(q2opts[0].label.length).toBeLessThanOrEqual(30);
|
|
});
|
|
});
|
|
});
|