oh-my-opencode/src/shared/agent-display-names.test.ts
YeonGyu-Kim c71a80a86c Revert name fields from agent configs, add getAgentConfigKey reverse lookup
Remove crash-causing name fields from 6 agent configs (sisyphus, hephaestus,
atlas, metis, momus, prometheus). The name field approach breaks opencode
because Agent.get(agent.name) uses name as lookup key.

Add getAgentConfigKey() to agent-display-names.ts for resolving display names
back to lowercase config keys (e.g. 'Atlas (Plan Executor)' -> 'atlas').
2026-02-16 20:42:45 +09:00

200 lines
6.1 KiB
TypeScript

import { describe, it, expect } from "bun:test"
import { AGENT_DISPLAY_NAMES, getAgentDisplayName, getAgentConfigKey } from "./agent-display-names"
describe("getAgentDisplayName", () => {
it("returns display name for lowercase config key (new format)", () => {
// given config key "sisyphus"
const configKey = "sisyphus"
// when getAgentDisplayName called
const result = getAgentDisplayName(configKey)
// then returns "Sisyphus (Ultraworker)"
expect(result).toBe("Sisyphus (Ultraworker)")
})
it("returns display name for uppercase config key (old format - case-insensitive)", () => {
// given config key "Sisyphus" (old format)
const configKey = "Sisyphus"
// when getAgentDisplayName called
const result = getAgentDisplayName(configKey)
// then returns "Sisyphus (Ultraworker)" (case-insensitive lookup)
expect(result).toBe("Sisyphus (Ultraworker)")
})
it("returns original key for unknown agents (fallback)", () => {
// given config key "custom-agent"
const configKey = "custom-agent"
// when getAgentDisplayName called
const result = getAgentDisplayName(configKey)
// then returns "custom-agent" (original key unchanged)
expect(result).toBe("custom-agent")
})
it("returns display name for atlas", () => {
// given config key "atlas"
const configKey = "atlas"
// when getAgentDisplayName called
const result = getAgentDisplayName(configKey)
// then returns "Atlas (Plan Executor)"
expect(result).toBe("Atlas (Plan Executor)")
})
it("returns display name for prometheus", () => {
// given config key "prometheus"
const configKey = "prometheus"
// when getAgentDisplayName called
const result = getAgentDisplayName(configKey)
// then returns "Prometheus (Plan Builder)"
expect(result).toBe("Prometheus (Plan Builder)")
})
it("returns display name for sisyphus-junior", () => {
// given config key "sisyphus-junior"
const configKey = "sisyphus-junior"
// when getAgentDisplayName called
const result = getAgentDisplayName(configKey)
// then returns "Sisyphus-Junior"
expect(result).toBe("Sisyphus-Junior")
})
it("returns display name for metis", () => {
// given config key "metis"
const configKey = "metis"
// when getAgentDisplayName called
const result = getAgentDisplayName(configKey)
// then returns "Metis (Plan Consultant)"
expect(result).toBe("Metis (Plan Consultant)")
})
it("returns display name for momus", () => {
// given config key "momus"
const configKey = "momus"
// when getAgentDisplayName called
const result = getAgentDisplayName(configKey)
// then returns "Momus (Plan Critic)"
expect(result).toBe("Momus (Plan Critic)")
})
it("returns display name for oracle", () => {
// given config key "oracle"
const configKey = "oracle"
// when getAgentDisplayName called
const result = getAgentDisplayName(configKey)
// then returns "oracle"
expect(result).toBe("oracle")
})
it("returns display name for librarian", () => {
// given config key "librarian"
const configKey = "librarian"
// when getAgentDisplayName called
const result = getAgentDisplayName(configKey)
// then returns "librarian"
expect(result).toBe("librarian")
})
it("returns display name for explore", () => {
// given config key "explore"
const configKey = "explore"
// when getAgentDisplayName called
const result = getAgentDisplayName(configKey)
// then returns "explore"
expect(result).toBe("explore")
})
it("returns display name for multimodal-looker", () => {
// given config key "multimodal-looker"
const configKey = "multimodal-looker"
// when getAgentDisplayName called
const result = getAgentDisplayName(configKey)
// then returns "multimodal-looker"
expect(result).toBe("multimodal-looker")
})
})
describe("getAgentConfigKey", () => {
it("resolves display name to config key", () => {
// given display name "Sisyphus (Ultraworker)"
// when getAgentConfigKey called
// then returns "sisyphus"
expect(getAgentConfigKey("Sisyphus (Ultraworker)")).toBe("sisyphus")
})
it("resolves display name case-insensitively", () => {
// given display name in different case
// when getAgentConfigKey called
// then returns "atlas"
expect(getAgentConfigKey("atlas (plan executor)")).toBe("atlas")
})
it("passes through lowercase config keys unchanged", () => {
// given lowercase config key "prometheus"
// when getAgentConfigKey called
// then returns "prometheus"
expect(getAgentConfigKey("prometheus")).toBe("prometheus")
})
it("returns lowercased unknown agents", () => {
// given unknown agent name
// when getAgentConfigKey called
// then returns lowercased
expect(getAgentConfigKey("Custom-Agent")).toBe("custom-agent")
})
it("resolves all core agent display names", () => {
// given all core display names
// when/then each resolves to its config key
expect(getAgentConfigKey("Hephaestus (Deep Agent)")).toBe("hephaestus")
expect(getAgentConfigKey("Prometheus (Plan Builder)")).toBe("prometheus")
expect(getAgentConfigKey("Atlas (Plan Executor)")).toBe("atlas")
expect(getAgentConfigKey("Metis (Plan Consultant)")).toBe("metis")
expect(getAgentConfigKey("Momus (Plan Critic)")).toBe("momus")
expect(getAgentConfigKey("Sisyphus-Junior")).toBe("sisyphus-junior")
})
})
describe("AGENT_DISPLAY_NAMES", () => {
it("contains all expected agent mappings", () => {
// given expected mappings
const expectedMappings = {
sisyphus: "Sisyphus (Ultraworker)",
hephaestus: "Hephaestus (Deep Agent)",
prometheus: "Prometheus (Plan Builder)",
atlas: "Atlas (Plan Executor)",
"sisyphus-junior": "Sisyphus-Junior",
metis: "Metis (Plan Consultant)",
momus: "Momus (Plan Critic)",
oracle: "oracle",
librarian: "librarian",
explore: "explore",
"multimodal-looker": "multimodal-looker",
}
// when checking the constant
// then contains all expected mappings
expect(AGENT_DISPLAY_NAMES).toEqual(expectedMappings)
})
})